From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 3/3] net/netvsc: add hyper-v netvsc network
	device
Date: Thu, 05 Apr 2018 22:52:31 +0200
Message-ID: <8666220.g7qk7zlF1B@xps>
References: <20180405191305.26813-1-sthemmin@microsoft.com>
 <20180405191305.26813-4-sthemmin@microsoft.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
To: Stephen Hemminger <sthemmin@microsoft.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 2E6D51CDBB
 for <dev@dpdk.org>; Thu,  5 Apr 2018 22:52:34 +0200 (CEST)
In-Reply-To: <20180405191305.26813-4-sthemmin@microsoft.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Stephen,

Good to see there is a good progress.

This patch should add an entry in the release notes.
But I guess it is not ready for 18.05?


05/04/2018 21:13, Stephen Hemminger:
> +#
> +# Compile native PMD for Hyper-V/Azure
> +#
> +CONFIG_RTE_LIBRTE_NETVSC_PMD=n
> +CONFIG_RTE_LIBRTE_NETVSC_DEBUG_RX=n
> +CONFIG_RTE_LIBRTE_NETVSC_DEBUG_TX=n
> +CONFIG_RTE_LIBRTE_NETVSC_DEBUG_DUMP=n

Please switch to the new dynamic logging.


[...]
> +the Data Plane Development Kit (DPDK), we provide a Netwwork Virtual

typo: Netwwork


> +The following prerequisites apply:
> +
> +*   Linux kernel uio_hv_generic driver that supports subchannels. This should be present in 4.17 or later.

The DPDK policy is to wait for prerequisite be available for merging.


> --- a/drivers/net/Makefile
> +++ b/drivers/net/Makefile
> @@ -46,6 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD) += thunderx
>  DIRS-$(CONFIG_RTE_LIBRTE_VDEV_NETVSC_PMD) += vdev_netvsc
>  DIRS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio
>  DIRS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD) += vmxnet3
> +DIRS-$(CONFIG_RTE_LIBRTE_NETVSC_PMD) += netvsc

Please keep the alphabetical order.