From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2] net/tap: return empty port offload capabilities Date: Thu, 26 Apr 2018 17:56:24 +0100 Message-ID: <868c93a7-70c3-72f7-3808-3f89d58ff5aa@intel.com> References: <1524672957-4018-1-git-send-email-ophirmu@mellanox.com> <1524741182-5758-1-git-send-email-ophirmu@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Thomas Monjalon , Olga Shern , stable@dpdk.org To: Ophir Munk , dev@dpdk.org, Pascal Mazon Return-path: In-Reply-To: <1524741182-5758-1-git-send-email-ophirmu@mellanox.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/26/2018 12:13 PM, Ophir Munk wrote: > Fix internal report on port specific offload capabilities to be 0 (no > capabilities). Before this commit port capabilities were a clone of queue > capabilities, however the current TAP offload capabilities (e.g. > checksum calculation) are per queue and are not specific per port. > This commit fixes an internal validation check for new configured > queue offloads. > The port capability API keeps reporting all queue capabilities as port > capabilities. > > Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API") > Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API") > Cc: stable@dpdk.org > > Signed-off-by: Ophir Munk Reviewed-by: Ferruh Yigit