From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4 22/23] ethdev: Decouple interrupt handling from PCI device Date: Thu, 22 Dec 2016 16:13:20 +0100 Message-ID: <8699988.5R756v89bM@xps13> References: <1482332986-7599-1-git-send-email-jblunck@infradead.org> <1482332986-7599-23-git-send-email-jblunck@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, shreyansh.jain@nxp.com, david.marchand@6wind.com, stephen@networkplumber.org To: Jan Blunck Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 1289510D88 for ; Thu, 22 Dec 2016 16:13:22 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id g23so178300500wme.1 for ; Thu, 22 Dec 2016 07:13:22 -0800 (PST) In-Reply-To: <1482332986-7599-23-git-send-email-jblunck@infradead.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-12-21 16:09, Jan Blunck: > The struct rte_intr_handle is an abstraction layer for different types of > interrupt mechanisms. It is embedded in the low-level device (e.g. PCI). > On allocation of a struct rte_eth_dev a reference to the intr_handle > should be stored for devices supporting interrupts. [...] > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -1629,6 +1629,7 @@ struct rte_eth_dev { > const struct eth_driver *driver;/**< Driver for this device */ > const struct eth_dev_ops *dev_ops; /**< Functions exported by PMD */ > struct rte_pci_device *pci_dev; /**< PCI info. supplied by probing */ > + struct rte_intr_handle *intr_handle; /**< Device interrupt handle */ > /** User application callbacks for NIC interrupts */ > struct rte_eth_dev_cb_list link_intr_cbs; > /** Why adding interrupt in ethdev? Shouldn't it be a property of rte_device?