From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 1/3] net/cxgbe: init data value before reading seeprom Date: Thu, 26 Jan 2017 11:06:52 +0000 Message-ID: <86a5a517-ac1e-fd2c-75f7-7f5598170e03@intel.com> References: <20170124204859.8998-1-emmanuel.roullit@gmail.com> <1d9bd589-e104-314c-ad07-ae98b8f5bda0@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, dpdk stable To: Emmanuel Roullit , rahul.lakkireddy@chelsio.com Return-path: In-Reply-To: <1d9bd589-e104-314c-ad07-ae98b8f5bda0@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/25/2017 12:12 PM, Ferruh Yigit wrote: > On 1/24/2017 8:48 PM, Emmanuel Roullit wrote: >> data value could have been garbage if VPD access timed out for VPD read >> request could not been issued. >> >> Found with clang static analysis: >> drivers/net/cxgbe/base/t4_hw.c:1577:22: >> warning: The left operand of '&' is a garbage value >> } while ((stats_reg & 0x1) && --max_poll); >> ~~~~~~~~~ ^ >> >> Fixes: 17ba077c5c54 ("net/cxgbe: support register dump") >> >> Signed-off-by: Emmanuel Roullit > > Applied to dpdk-next-net/master, thanks. > Fixes: fe0bd9ee5da3 ("net/cxgbe: support EEPROM access") Cc: stable@dpdk.org