From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] rte_eth_af_packet: refactor error handling
	to avoid NULL pointer dereference
Date: Tue, 20 Oct 2015 09:02:04 -0700 (PDT)
Message-ID: <8727896.bTnbiDNnpp@xps13>
References: <1440695833-28778-1-git-send-email-linville@tuxdriver.com>
 <20150828102742.GA3351@hmsreliant.think-freely.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "John W. Linville" <linville@tuxdriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com
 [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id D621D5957
 for <dev@dpdk.org>; Tue, 20 Oct 2015 18:02:05 +0200 (CEST)
Received: by wicll6 with SMTP id ll6so52505511wic.0
 for <dev@dpdk.org>; Tue, 20 Oct 2015 09:02:05 -0700 (PDT)
In-Reply-To: <20150828102742.GA3351@hmsreliant.think-freely.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-08-28 06:27, Neil Horman:
> On Thu, Aug 27, 2015 at 01:17:13PM -0400, John W. Linville wrote:
> > Coverity CID # 13321
> > 
> > Checking *internals != NULL before accessing req is not good enough,
> > because **internals is a function argument and the function doesn't
> > really know what is passed-in.  We can close our eyes and ignore the
> > warning on the basis of controlling all the calling code, or we can
> > refactor the error exit to avoid the issue entirely...
> > 
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> 
> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Applied, thanks