From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v7 0/5] Support NIC reset and keep same port id Date: Sun, 16 Jul 2017 21:25:34 +0200 Message-ID: <8733823.mcBcVaCldc@xps> References: <1499681144-26031-1-git-send-email-wei.dai@intel.com> <1499961223-45281-1-git-send-email-wei.dai@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, john.mcnamara@intel.com To: Wei Dai Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1645523D for ; Sun, 16 Jul 2017 23:42:44 +0200 (CEST) In-Reply-To: <1499961223-45281-1-git-send-email-wei.dai@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/07/2017 17:53, Wei Dai: > chagnes: > v7: > add description of NIC reset in doc/poll_mode_drv.rst Thanks for bringing more explanations. The texts have to be reviewed by a native english speaker. About the organization of the doc, it is good to explain the VF use case in the prog guide as you do. But you should not add it to the doxygen. The doxygen must be concise enough and explains only the API: - when it can be called - what a driver is doing when calling reset - what is the expected state of the device after reset