From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2] doc: add tso capabilities feature for mlx5
Date: Mon, 23 Jan 2017 12:29:57 +0000
Message-ID: <87f45d60-baaa-f829-d60c-0279aa9769e3@intel.com>
References: <1483892601-6997-1-git-send-email-eladpe@mellanox.com>
 <3c5731c6-4213-c976-9a17-798eb24d2c37@intel.com>
 <HE1PR0501MB2473D194ADE0BD539B3796D1BC670@HE1PR0501MB2473.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
To: Elad Persiko <eladpe@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id D85572BE9
 for <dev@dpdk.org>; Mon, 23 Jan 2017 13:29:59 +0100 (CET)
In-Reply-To: <HE1PR0501MB2473D194ADE0BD539B3796D1BC670@HE1PR0501MB2473.eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/10/2017 9:18 AM, Elad Persiko wrote:
> 
> Thanks,
> The feature is not supported on MLX4. I will fix it on V2

The new version of this patch will be squashed to "net/mlx5: last WQE no
room inline" patchset, right?

> 
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Monday, January 9, 2017 2:31 PM
> To: Elad Persiko <eladpe@mellanox.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] doc: add tso capabilities feature for mlx5
> 
> On 1/8/2017 4:23 PM, Elad Persiko wrote:
>> Feature implemented at:
>> commit b007e98ccda9 ("net/mlx5: implement TSO data path") commit 
>> 085c4137280a ("net/mlx5: support TSO in control plane")
>>
>> Signed-off-by: Elad Persiko <eladpe@mellanox.com>
>> ---
>>  doc/guides/nics/features/mlx4.ini | 1 + 
>> doc/guides/nics/features/mlx5.ini | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/doc/guides/nics/features/mlx4.ini
>> b/doc/guides/nics/features/mlx4.ini
>> index c9828f7..d74b9dd 100644
>> --- a/doc/guides/nics/features/mlx4.ini
>> +++ b/doc/guides/nics/features/mlx4.ini
>> @@ -10,6 +10,7 @@ Queue start/stop     = Y
>>  MTU update           = Y
>>  Jumbo frame          = Y
>>  Scattered Rx         = Y
>> +TSO                  = Y
> 
> One more thing, for double check, patch updates only mlx5 files, is enabling TSO for mlx4 correct?
> 
>>  Promiscuous mode     = Y
>>  Allmulticast mode    = Y
>>  Unicast MAC filter   = Y
> <...>
>