* [dpdk-dev] [PATCH] doc: announce changes in security session struct
@ 2021-08-03 12:23 Akhil Goyal
2021-08-03 12:36 ` Ananyev, Konstantin
0 siblings, 1 reply; 6+ messages in thread
From: Akhil Goyal @ 2021-08-03 12:23 UTC (permalink / raw)
To: dev
Cc: anoobj, radu.nicolau, declan.doherty, hemant.agrawal, matan,
konstantin.ananyev, thomas, roy.fan.zhang, asomalap, ruifeng.wang,
ajit.khaparde, pablo.de.lara.guarch, fiona.trahe, adwivedi,
michaelsh, rnagadheeraj, jianjay.zhou, Akhil Goyal
The structure rte_security_session is not directly used
by the application. The application just need an opaque
pointer to attached to the mbuf or rte_crypto_op while
enqueue. Hence, it can be hidden inside the library
and would prevent unnecessary indirection to the priv
session data in fastpath.
Signed-off-by: Akhil Goyal <gakhil@marvell.com>
---
doc/guides/rel_notes/deprecation.rst | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index c540c90f8e..8da1c2648c 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -159,3 +159,7 @@ Deprecation Notices
* security: The functions ``rte_security_set_pkt_metadata`` and
``rte_security_get_userdata`` will be made inline functions and additional
flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
+
+* security: Hide stucture ``rte_security_session`` and expose an opaque
+ pointer for the private data to the application which can be attached
+ to the packet while enqueuing.
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce changes in security session struct
2021-08-03 12:23 [dpdk-dev] [PATCH] doc: announce changes in security session struct Akhil Goyal
@ 2021-08-03 12:36 ` Ananyev, Konstantin
2021-08-03 18:01 ` Ajit Khaparde
0 siblings, 1 reply; 6+ messages in thread
From: Ananyev, Konstantin @ 2021-08-03 12:36 UTC (permalink / raw)
To: Akhil Goyal, dev@dpdk.org
Cc: anoobj@marvell.com, Nicolau, Radu, Doherty, Declan,
hemant.agrawal@nxp.com, matan@nvidia.com, thomas@monjalon.net,
Zhang, Roy Fan, asomalap@amd.com, ruifeng.wang@arm.com,
ajit.khaparde@broadcom.com, De Lara Guarch, Pablo, Trahe, Fiona,
adwivedi@marvell.com, michaelsh@marvell.com,
rnagadheeraj@marvell.com, jianjay.zhou@huawei.com
> The structure rte_security_session is not directly used
> by the application. The application just need an opaque
> pointer to attached to the mbuf or rte_crypto_op while
> enqueue. Hence, it can be hidden inside the library
> and would prevent unnecessary indirection to the priv
> session data in fastpath.
>
> Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index c540c90f8e..8da1c2648c 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -159,3 +159,7 @@ Deprecation Notices
> * security: The functions ``rte_security_set_pkt_metadata`` and
> ``rte_security_get_userdata`` will be made inline functions and additional
> flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
> +
> +* security: Hide stucture ``rte_security_session`` and expose an opaque
> + pointer for the private data to the application which can be attached
> + to the packet while enqueuing.
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce changes in security session struct
2021-08-03 12:36 ` Ananyev, Konstantin
@ 2021-08-03 18:01 ` Ajit Khaparde
2021-08-05 4:15 ` [dpdk-dev] [EXT] " Anoob Joseph
0 siblings, 1 reply; 6+ messages in thread
From: Ajit Khaparde @ 2021-08-03 18:01 UTC (permalink / raw)
To: Ananyev, Konstantin
Cc: Akhil Goyal, dev@dpdk.org, anoobj@marvell.com, Nicolau, Radu,
Doherty, Declan, hemant.agrawal@nxp.com, matan@nvidia.com,
thomas@monjalon.net, Zhang, Roy Fan, asomalap@amd.com,
ruifeng.wang@arm.com, De Lara Guarch, Pablo, Trahe, Fiona,
adwivedi@marvell.com, michaelsh@marvell.com,
rnagadheeraj@marvell.com, jianjay.zhou@huawei.com
[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]
On Tue, Aug 3, 2021 at 5:36 AM Ananyev, Konstantin
<konstantin.ananyev@intel.com> wrote:
>
>
> > The structure rte_security_session is not directly used
> > by the application. The application just need an opaque
> > pointer to attached to the mbuf or rte_crypto_op while
> > enqueue. Hence, it can be hidden inside the library
> > and would prevent unnecessary indirection to the priv
> > session data in fastpath.
> >
> > Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> > ---
> > doc/guides/rel_notes/deprecation.rst | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index c540c90f8e..8da1c2648c 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -159,3 +159,7 @@ Deprecation Notices
> > * security: The functions ``rte_security_set_pkt_metadata`` and
> > ``rte_security_get_userdata`` will be made inline functions and additional
> > flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
> > +
> > +* security: Hide stucture ``rte_security_session`` and expose an opaque
> > + pointer for the private data to the application which can be attached
> > + to the packet while enqueuing.
> > --
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
> > 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [EXT] Re: [PATCH] doc: announce changes in security session struct
2021-08-03 18:01 ` Ajit Khaparde
@ 2021-08-05 4:15 ` Anoob Joseph
2021-08-07 13:34 ` Jerin Jacob
0 siblings, 1 reply; 6+ messages in thread
From: Anoob Joseph @ 2021-08-05 4:15 UTC (permalink / raw)
To: Ajit Khaparde, Ananyev, Konstantin
Cc: Akhil Goyal, dev@dpdk.org, Nicolau, Radu, Doherty, Declan,
hemant.agrawal@nxp.com, matan@nvidia.com, thomas@monjalon.net,
Zhang, Roy Fan, asomalap@amd.com, ruifeng.wang@arm.com,
De Lara Guarch, Pablo, Trahe, Fiona, Ankur Dwivedi,
Michael Shamis, Nagadheeraj Rottela, jianjay.zhou@huawei.com
> Subject: [EXT] Re: [PATCH] doc: announce changes in security session struct
>
>
> On Tue, Aug 3, 2021 at 5:36 AM Ananyev, Konstantin
> <konstantin.ananyev@intel.com> wrote:
> >
> >
> > > The structure rte_security_session is not directly used
> > > by the application. The application just need an opaque
> > > pointer to attached to the mbuf or rte_crypto_op while
> > > enqueue. Hence, it can be hidden inside the library
> > > and would prevent unnecessary indirection to the priv
> > > session data in fastpath.
> > >
> > > Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> > > ---
> > > doc/guides/rel_notes/deprecation.rst | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> > > index c540c90f8e..8da1c2648c 100644
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > @@ -159,3 +159,7 @@ Deprecation Notices
> > > * security: The functions ``rte_security_set_pkt_metadata`` and
> > > ``rte_security_get_userdata`` will be made inline functions and additional
> > > flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
> > > +
> > > +* security: Hide stucture ``rte_security_session`` and expose an opaque
> > > + pointer for the private data to the application which can be attached
> > > + to the packet while enqueuing.
> > > --
> >
> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [EXT] Re: [PATCH] doc: announce changes in security session struct
2021-08-05 4:15 ` [dpdk-dev] [EXT] " Anoob Joseph
@ 2021-08-07 13:34 ` Jerin Jacob
2021-08-07 17:08 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Jerin Jacob @ 2021-08-07 13:34 UTC (permalink / raw)
To: Anoob Joseph
Cc: Ajit Khaparde, Ananyev, Konstantin, Akhil Goyal, dev@dpdk.org,
Nicolau, Radu, Doherty, Declan, hemant.agrawal@nxp.com,
matan@nvidia.com, thomas@monjalon.net, Zhang, Roy Fan,
asomalap@amd.com, ruifeng.wang@arm.com, De Lara Guarch, Pablo,
Trahe, Fiona, Ankur Dwivedi, Michael Shamis, Nagadheeraj Rottela,
jianjay.zhou@huawei.com
On Thu, Aug 5, 2021 at 9:45 AM Anoob Joseph <anoobj@marvell.com> wrote:
>
> > Subject: [EXT] Re: [PATCH] doc: announce changes in security session struct
> >
> >
> > On Tue, Aug 3, 2021 at 5:36 AM Ananyev, Konstantin
> > <konstantin.ananyev@intel.com> wrote:
> > >
> > >
> > > > The structure rte_security_session is not directly used
> > > > by the application. The application just need an opaque
> > > > pointer to attached to the mbuf or rte_crypto_op while
> > > > enqueue. Hence, it can be hidden inside the library
> > > > and would prevent unnecessary indirection to the priv
> > > > session data in fastpath.
> > > >
> > > > Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> > > > ---
> > > > doc/guides/rel_notes/deprecation.rst | 4 ++++
> > > > 1 file changed, 4 insertions(+)
> > > >
> > > > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > > > index c540c90f8e..8da1c2648c 100644
> > > > --- a/doc/guides/rel_notes/deprecation.rst
> > > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > > @@ -159,3 +159,7 @@ Deprecation Notices
> > > > * security: The functions ``rte_security_set_pkt_metadata`` and
> > > > ``rte_security_get_userdata`` will be made inline functions and additional
> > > > flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
> > > > +
> > > > +* security: Hide stucture ``rte_security_session`` and expose an opaque
> > > > + pointer for the private data to the application which can be attached
> > > > + to the packet while enqueuing.
> > > > --
> > >
> > > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [EXT] Re: [PATCH] doc: announce changes in security session struct
2021-08-07 13:34 ` Jerin Jacob
@ 2021-08-07 17:08 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2021-08-07 17:08 UTC (permalink / raw)
To: Akhil Goyal
Cc: Anoob Joseph, dev, Ajit Khaparde, Ananyev, Konstantin,
dev@dpdk.org, Nicolau, Radu, Doherty, Declan,
hemant.agrawal@nxp.com, matan@nvidia.com, Zhang, Roy Fan,
asomalap@amd.com, ruifeng.wang@arm.com, De Lara Guarch, Pablo,
Trahe, Fiona, Ankur Dwivedi, Michael Shamis, Nagadheeraj Rottela,
jianjay.zhou@huawei.com, Jerin Jacob
> > > > > The structure rte_security_session is not directly used
> > > > > by the application. The application just need an opaque
> > > > > pointer to attached to the mbuf or rte_crypto_op while
> > > > > enqueue. Hence, it can be hidden inside the library
> > > > > and would prevent unnecessary indirection to the priv
> > > > > session data in fastpath.
> > > > >
> > > > > Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> > > > > ---
> > > > > +* security: Hide stucture ``rte_security_session`` and expose an opaque
> > > > > + pointer for the private data to the application which can be attached
> > > > > + to the packet while enqueuing.
> > > >
> > > > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > Acked-by: Anoob Joseph <anoobj@marvell.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-08-07 17:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-03 12:23 [dpdk-dev] [PATCH] doc: announce changes in security session struct Akhil Goyal
2021-08-03 12:36 ` Ananyev, Konstantin
2021-08-03 18:01 ` Ajit Khaparde
2021-08-05 4:15 ` [dpdk-dev] [EXT] " Anoob Joseph
2021-08-07 13:34 ` Jerin Jacob
2021-08-07 17:08 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).