From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] config: compile avp driver only on intel 64 bit Date: Wed, 05 Apr 2017 10:58:47 +0200 Message-ID: <8825815.qbYC4VjRtT@xps13> References: <20170404163654.86100-1-allain.legacy@windriver.com> <4712ffa9-b81c-bdef-ccc0-ae508d5b327d@intel.com> <20170405082308.GA19612@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Bruce Richardson , Ferruh Yigit , Allain Legacy Return-path: Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id D88D81DB1 for ; Wed, 5 Apr 2017 10:58:49 +0200 (CEST) Received: by mail-wr0-f179.google.com with SMTP id w43so4755049wrb.0 for ; Wed, 05 Apr 2017 01:58:49 -0700 (PDT) In-Reply-To: <20170405082308.GA19612@bricha3-MOBL3.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-04-05 09:23, Bruce Richardson: > On Tue, Apr 04, 2017 at 06:12:12PM +0100, Ferruh Yigit wrote: > > On 4/4/2017 5:36 PM, Allain Legacy wrote: > > > The AVP devices are only supported on Intel 64-bit architectures so > > > adjusting the defconfig attributes accordingly. > > > > > > Fixes: c5ab4707ba97 ("net/avp: support driver registration") > > > > > > Signed-off-by: Allain Legacy > > > --- > > > config/common_linuxapp | 1 - > > > config/defconfig_i686-native-linuxapp-gcc | 5 ----- > > > config/defconfig_i686-native-linuxapp-icc | 5 ----- > > > config/defconfig_x86_64-native-linuxapp-clang | 5 +++++ > > > > Right now compiler config files only have compiler and architecture > > configs, although it is OK to update them, to be consistent with what > > other PMDs did, what do you think: > > > > Keep AVP config enabled in "common_linuxapp" > > > > Disable AVP in following configs: > > defconfig_arm64-armv8a-linuxapp-gcc > > defconfig_arm-armv7a-linuxapp-gcc > > defconfig_ppc_64-power8-linuxapp-gcc > > > > I actually disagree with that, and I think the approach proposed is > better, given that it's only one target type that is supported. > > However, I think we should have an AVP config option in common base, set > to "n", so that we at least there have an entry to indicate it exists. Yes, seems reasonnable