From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [RFC PATCH 0/6] change legacy linuxapp/bsdapp names Date: Sat, 09 Mar 2019 01:57:43 +0100 Message-ID: <8835039.k5sPRo0dVy@xps> References: <20190306162242.65375-1-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 9DBF12B87 for ; Sat, 9 Mar 2019 01:57:46 +0100 (CET) In-Reply-To: <20190306162242.65375-1-bruce.richardson@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/03/2019 17:22, Bruce Richardson: > The terms linuxapp and bsdapp are legacy names in DPDK that are equivalent > to the more usual names of "linux" and "freebsd". Therefore, we can > replace the instances of the "app" names with the more usual variants. The > only issue in maintaining backward compatibility which can be done by > preserving a) the build config filenames and b) the macros defined for > the build. In both cases, new configs/macros are added while keeping the > old for compatiblity. > > The first 5 patches are relatively minor, internal changes, or changes for > the newer meson system. Patch 6 is larger in size as it changes the > make build system which has far greater use of the names linuxapp and > bsdapp. > > Bruce Richardson (6): > eal/bsdapp: rename to freebsd > eal/linuxapp: rename to linux > build/linux: rename macro from LINUXAPP to LINUX > build/freebsd: rename macro from BSDPAPP to FREEBSD > build/meson: change linuxapp to linux in meson cross files > build: allow linux and freebsd in build configs I agree on the idea. If no issue is found, I'll apply it shortly to avoid too many rebase issue. If someone is against, please shout before Tuesday.