From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] meson: fix compilation with binutils version 2.30 Date: Thu, 17 Jan 2019 17:23:36 +0000 Message-ID: <884f29ec-a85d-41f2-abd7-17b5bbeea3bb@intel.com> References: <20190117171744.63455-1-harry.van.haaren@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: bruce.richardson@intel.com, thomas@monjalon.net To: Harry van Haaren , dev@dpdk.org Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 3B8182BDB for ; Thu, 17 Jan 2019 18:23:39 +0100 (CET) In-Reply-To: <20190117171744.63455-1-harry.van.haaren@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/17/2019 5:17 PM, Harry van Haaren wrote: > This commit reworks the checks for binutils 2.30 and how > the flags to disable AVX512F are passed to the compiler. > > Previously the #define for including AVX512 code was set, > while the -mno-avx512f argument was given to the compiler. > This would cause gcc to correctly refuse to emit AVX512 > instructions, but the rte_memcpy code that includes AVX512 > optimizations was being added to the build. > > The check for binutils check is now moved to x86 as it is > irrelevant for other architectures, and the -mno-avx512f > flag is passed to a march_opts array in meson. As the > -mno-avx512 flag is added earlier in the build, the code > in rte_memcpy is no longer attempted to be compiled. > > This commit also adds a message print in the meson configure > stage to alert the user of the workaround being employed. > > Fixes: a32ca9a4ebc1 ("mk: fix scope of disabling AVX512F support") > > Signed-off-by: Harry van Haaren Tested-by: Ferruh Yigit Thanks for the fix Harry.