From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] pci: fix build on FreeBSD
Date: Mon, 03 Aug 2015 17:49:15 +0200
Message-ID: <8853406.AiVMUm1C9c@xps13>
References: <1438263693-24165-1-git-send-email-thomas.monjalon@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id D114BC3BE
 for <dev@dpdk.org>; Mon,  3 Aug 2015 17:50:29 +0200 (CEST)
Received: by wibud3 with SMTP id ud3so141772110wib.1
 for <dev@dpdk.org>; Mon, 03 Aug 2015 08:50:29 -0700 (PDT)
In-Reply-To: <1438263693-24165-1-git-send-email-thomas.monjalon@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Stephen,

> By the way, it seems strange that pi_data is initialized twice:
> 	.pi_data = *(u_int32_t *)buf
> 	memcpy(&pi.pi_data, buf, len);

Please, could you explain why there are 2 initializations of pi_data
in lib/librte_eal/bsdapp/eal/eal_pci.c?