From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83406C433E0 for ; Mon, 29 Jun 2020 20:40:57 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 2019120663 for ; Mon, 29 Jun 2020 20:40:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="xBkn4Erd"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="vTKf9dwP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2019120663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C6C21BEE3; Mon, 29 Jun 2020 22:40:56 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 8DDBC1BEDF for ; Mon, 29 Jun 2020 22:40:54 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id D2028580426; Mon, 29 Jun 2020 16:40:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 29 Jun 2020 16:40:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= /JFGzozkUcIUos3sWydzI9AfNQPkjqirwcgCL859SK4=; b=xBkn4ErdoLnFLsHh UbK7JYowKTxhbSN9FGUEeyxWnhCkkA5xD9Oy84Gk1IbM1UE0kdfMuX8Y0kfJRFsK lUk/zWuOS2dZ7wZp97oL47437GR1GH4yoZa4H8NbzBgwA0aXy3BvLgtzd9rY6UTT s7U9UJMRZ7T8Zt4zTok7+gO9DR0zIHV8MgG6ueCyze56jCzSZSBnOcE8/3l7HSgZ 8xqtxx9kesBRHIh8hX2faFg3+oHWMv4rgLthoavD6N9L/nbkPaYojUcRJssxMDMj qRvIlLrFBm1gFvBHazSPeEOjIpwJsn8ut/xl6kSvWKtGk448Of/8WX1PiQSAp8vW jWmuDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=/JFGzozkUcIUos3sWydzI9AfNQPkjqirwcgCL859S K4=; b=vTKf9dwPuQ4CMKfmk4eU23RqFqlxIWfqA+6He013EjZoktJwqjju99KJB mw1MX6HYfaZLebBnEfQQPSXHyTnnvnp2GtwWB7wVFzWsR34w3kIvJbM1CkgYfPtr QKfv+R4giFUNISzaPnvoYzfMf8ZEXHBTgmrJJ5XrVhYeA7zYjzqQ3TdHT36TXaLg vp48WyYdif0hN12sYv5tdqKW18BZ3l/vHU1msJWuFeBfANiS2Kgmh3z2pPFwpnhf WmD42FpwKLpv8iwaRC8VoKLhUvjfwWnRZF3vAHlzJNAt6U9rY/1quG6qSVPpqv5k Q8Aye3mg3KfHTNEeUYqQxcT3polLw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudelledgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E29753067AB1; Mon, 29 Jun 2020 16:40:51 -0400 (EDT) From: Thomas Monjalon To: Tal Shnaiderman Cc: dev@dpdk.org, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, david.marchand@redhat.com, grive@u256.net, ranjit.menon@intel.com, navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, anatoly.burakov@intel.com, fady@mellanox.com, bruce.richardson@intel.com Date: Mon, 29 Jun 2020 22:40:50 +0200 Message-ID: <8865158.m9mE935L7l@thomas> In-Reply-To: <20200629123741.20716-9-talshn@mellanox.com> References: <20200624082847.21344-1-talshn@mellanox.com> <20200629123741.20716-1-talshn@mellanox.com> <20200629123741.20716-9-talshn@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v10 08/10] bus/pci: introduce Windows support with stubs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/06/2020 14:37, talshn@mellanox.com: > +if host_machine.system() == 'windows' Should be is_windows. [...] > +if host_machine.system() == 'bsd' Should be 'freebsd', or even better, is_freebsd.