* [PATCH] rte_ring: add newline to error message
@ 2019-03-21 23:03 Stephen Hemminger
2019-03-22 9:49 ` Rami Rosen
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Stephen Hemminger @ 2019-03-21 23:03 UTC (permalink / raw)
To: olivier.matz, pablo.de.lara.guarch; +Cc: dev, Stephen Hemminger
Log message should end with newline.
Fixes: 4e32101f9b01 ("ring: support freeing")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/librte_ring/rte_ring.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_ring/rte_ring.c b/lib/librte_ring/rte_ring.c
index d215aceccf46..61534b286b53 100644
--- a/lib/librte_ring/rte_ring.c
+++ b/lib/librte_ring/rte_ring.c
@@ -189,7 +189,8 @@ rte_ring_free(struct rte_ring *r)
* therefore, there is no memzone to free.
*/
if (r->memzone == NULL) {
- RTE_LOG(ERR, RING, "Cannot free ring (not created with rte_ring_create()");
+ RTE_LOG(ERR, RING,
+ "Cannot free ring (not created with rte_ring_create()\n");
return;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] rte_ring: add newline to error message
2019-03-21 23:03 [PATCH] rte_ring: add newline to error message Stephen Hemminger
@ 2019-03-22 9:49 ` Rami Rosen
2019-03-27 11:21 ` Thomas Monjalon
2019-04-02 15:30 ` [PATCH v2] " Stephen Hemminger
2 siblings, 0 replies; 5+ messages in thread
From: Rami Rosen @ 2019-03-22 9:49 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Olivier Matz, Pablo De Lara Guarch, dev
On Fri, Mar 22, 2019 at 1:04 AM Stephen Hemminger <
stephen@networkplumber.org> wrote:
> Log message should end with newline.
>
> Fixes: 4e32101f9b01 ("ring: support freeing")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>
Reviewed-by: Rami Rosen <ramirose@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] rte_ring: add newline to error message
2019-03-21 23:03 [PATCH] rte_ring: add newline to error message Stephen Hemminger
2019-03-22 9:49 ` Rami Rosen
@ 2019-03-27 11:21 ` Thomas Monjalon
2019-04-02 15:30 ` [PATCH v2] " Stephen Hemminger
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2019-03-27 11:21 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, olivier.matz, pablo.de.lara.guarch, ramirose
22/03/2019 00:03, Stephen Hemminger:
> Log message should end with newline.
>
> Fixes: 4e32101f9b01 ("ring: support freeing")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> - RTE_LOG(ERR, RING, "Cannot free ring (not created with rte_ring_create()");
> + RTE_LOG(ERR, RING,
> + "Cannot free ring (not created with rte_ring_create()\n");
While at it, could you fix the parens?
I think it would be better to replace the first paren with a comma.
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] rte_ring: add newline to error message
2019-03-21 23:03 [PATCH] rte_ring: add newline to error message Stephen Hemminger
2019-03-22 9:49 ` Rami Rosen
2019-03-27 11:21 ` Thomas Monjalon
@ 2019-04-02 15:30 ` Stephen Hemminger
2019-04-03 16:40 ` Thomas Monjalon
2 siblings, 1 reply; 5+ messages in thread
From: Stephen Hemminger @ 2019-04-02 15:30 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger
Log message should end with newline.
Fixes: 4e32101f9b01 ("ring: support freeing")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Rami Rosen <ramirose@gmail.com>
---
v2 -- fix punctuation in message as well
lib/librte_ring/rte_ring.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_ring/rte_ring.c b/lib/librte_ring/rte_ring.c
index d215aceccf46..550549db3924 100644
--- a/lib/librte_ring/rte_ring.c
+++ b/lib/librte_ring/rte_ring.c
@@ -189,7 +189,8 @@ rte_ring_free(struct rte_ring *r)
* therefore, there is no memzone to free.
*/
if (r->memzone == NULL) {
- RTE_LOG(ERR, RING, "Cannot free ring (not created with rte_ring_create()");
+ RTE_LOG(ERR, RING,
+ "Cannot free ring, not created with rte_ring_create()\n");
return;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] rte_ring: add newline to error message
2019-04-02 15:30 ` [PATCH v2] " Stephen Hemminger
@ 2019-04-03 16:40 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2019-04-03 16:40 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
02/04/2019 17:30, Stephen Hemminger:
> Log message should end with newline.
>
> Fixes: 4e32101f9b01 ("ring: support freeing")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Reviewed-by: Rami Rosen <ramirose@gmail.com>
> ---
> v2 -- fix punctuation in message as well
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-03 16:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-21 23:03 [PATCH] rte_ring: add newline to error message Stephen Hemminger
2019-03-22 9:49 ` Rami Rosen
2019-03-27 11:21 ` Thomas Monjalon
2019-04-02 15:30 ` [PATCH v2] " Stephen Hemminger
2019-04-03 16:40 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).