From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal/x86: fix pedantic build
Date: Thu, 04 Apr 2019 17:23:26 +0200
Message-ID: <8884422.lsyktsHzmi@xps>
References: <20190404130009.22042-1-thomas@monjalon.net>
 <9184057F7FC11744A2107296B6B8EB1E54210E11@FMSMSX108.amr.corp.intel.com>
 <9ef6aa9a-2bf6-8eb9-b184-ce962b2355f8@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Richardson,
 Bruce" <bruce.richardson@intel.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>,
 "david.marchand@redhat.com" <david.marchand@redhat.com>,
 "alialnu@mellanox.com" <alialnu@mellanox.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "Eads, Gage" <gage.eads@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id B7B5F1B3BA
 for <dev@dpdk.org>; Thu,  4 Apr 2019 17:23:30 +0200 (CEST)
In-Reply-To: <9ef6aa9a-2bf6-8eb9-b184-ce962b2355f8@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

04/04/2019 17:13, Ferruh Yigit:
> On 4/4/2019 3:14 PM, Eads, Gage wrote:
> >> 04/04/2019 15:00, Thomas Monjalon:
> >>> When enabling pedantic compilation with
> >> CONFIG_RTE_LIBRTE_MLX5_DEBUG,
> >>> the compiler complains about non standard 128-bit integer type:
> >>>
> >>> include/rte_atomic_64.h:223:3: error:
> >>> ISO C does not support =E2=80=98__int128=E2=80=99 types [-Werror=3Dpe=
dantic]
> >>>
> >>> It must be marked as an extension of the standard C language to be
> >>> accepted in pedantic compilation.
> >>>
> >>> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >>
> >> Forgot one line:
> >>
> >> Fixes: 640c5f09ef2c ("eal/x86: add 128-bit atomic compare exchange")
> >>
> >> Note: It seems only Ferruh can reproduce it.
> >> I wonder whether the RTE_STD_C11 of the union is hiding the issue.
> >=20
> > With that change:
> > Acked-by: Gage Eads <gage.eads@intel.com>
> >=20
>=20
> I confirm it fixes the build issue:
>=20
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks