From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] enic: silence log message unless debug enabled Date: Thu, 30 Jul 2015 21:18:06 +0200 Message-ID: <8905831.sre1Q7tU6v@xps13> References: <1428514670-7982-1-git-send-email-stephen@networkplumber.org> <1428514670-7982-2-git-send-email-stephen@networkplumber.org> <20150730100338.76cd581b@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Stephen Hemminger Return-path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id C4B67C6C4 for ; Thu, 30 Jul 2015 21:19:24 +0200 (CEST) Received: by wibud3 with SMTP id ud3so4673237wib.0 for ; Thu, 30 Jul 2015 12:19:24 -0700 (PDT) In-Reply-To: <20150730100338.76cd581b@urahara> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-30 10:03, Stephen Hemminger: > --- a/drivers/net/enic/enic_compat.h > +++ b/drivers/net/enic/enic_compat.h > @@ -82,7 +82,11 @@ > #define dev_err(x, args...) dev_printk(ERR, args) > #define dev_info(x, args...) dev_printk(INFO, args) > #define dev_warning(x, args...) dev_printk(WARNING, args) > +#ifdef RTE_LIBRTE_ENIC_DEBUG > #define dev_debug(x, args...) dev_printk(DEBUG, args) > +#else > +#define dev_debug(x, args...) do { } while(0) > +#endif I don't understand why it is needed: dev_debug won't print anything if the log level is higher than DEBUG.