From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCH v2 1/2] ethdev: add callback to get register size in bytes Date: Mon, 30 May 2016 13:58:45 +0300 Message-ID: <89305686-998b-9f36-d2c2-dc6ec123c5c5@redhat.com> References: <1464601185-7330-1-git-send-email-zr@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: zr@semihalf.com Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D5E0D3977 for ; Mon, 30 May 2016 12:58:47 +0200 (CEST) In-Reply-To: <1464601185-7330-1-git-send-email-zr@semihalf.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/30/2016 12:39 PM, zr@semihalf.com wrote: > From: Zyta Szpak > > Version 2 of fixing the fixed register width assumption. > rte_eth_dev_get_reg_length and rte_eth_dev_get_reg callbacks > do not provide register size to the app in any way. It is > needed to allocate proper number of bytes before retrieving > registers content with rte_eth_dev_get_reg. > > Signed-off-by: Zyta Szpak [...] > diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map > index 214ecc7..288bc63 100644 > --- a/lib/librte_ether/rte_ether_version.map > +++ b/lib/librte_ether/rte_ether_version.map > @@ -130,5 +130,6 @@ DPDK_16.04 { > rte_eth_tx_buffer_drop_callback; > rte_eth_tx_buffer_init; > rte_eth_tx_buffer_set_err_callback; > + rte_eth_dev_get_reg_width; > > } DPDK_2.2; This symbol did not exist in DPDK 16.04 so it must not be added there. Add a new section for 16.07 which inherits from DPDK_16.04. - Panu -