From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] cmdline: fix ressize in parse_portlist Date: Fri, 20 Feb 2015 10:52:11 +0100 Message-ID: <8959296.RnBG6Of9nb@xps13> References: <1423043365-28462-1-git-send-email-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Olivier Matz Return-path: In-Reply-To: <1423043365-28462-1-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-02-04 10:49, Olivier Matz: > The argument ressize contains the size of the result buffer which > should be large enough to store the parsed result of a token. In > this case, it should be larger or equal to sizeof(cmdline_portlist_t) > (4 bytes), not PORTLIST_TOKEN_SIZE which is the max size of the token > string. > > This is not a critical, it fixes cases where the total length of the > parsed instruction is greater than the maximum. > > Signed-off-by: Olivier Matz Applied, thanks