From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] test-meson-builds: allow building outside
 source dir
Date: Mon, 01 Apr 2019 17:23:39 +0100
Message-ID: <8977f5e0dc0fa4c5ecf9e973c6d751b797458d9f.camel@debian.org>
References: <20190401160833.38213-1-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>, thomas@monjalon.net
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com
 [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 801215323
 for <dev@dpdk.org>; Mon,  1 Apr 2019 18:23:41 +0200 (CEST)
Received: by mail-wr1-f66.google.com with SMTP id k11so12880407wro.5
 for <dev@dpdk.org>; Mon, 01 Apr 2019 09:23:41 -0700 (PDT)
In-Reply-To: <20190401160833.38213-1-bruce.richardson@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 2019-04-01 at 17:08 +0100, Bruce Richardson wrote:
> The test-meson-builds.sh script correctly detects the source
> directory and
> builds the native builds successfully in a directory outside of the
> source
> tree. However, the paths to the cross-files are not prefixed with the
> source directory path, so the cross-builds all fail. Fix this by
> prepending
> the source directory path appropriately.
>=20
> Signed-off-by: Bruce Richardson <
> bruce.richardson@intel.com
> >
> ---
>  devtools/test-meson-builds.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-
> builds.sh
> index e3f19a01a..b3b5cfbb5 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -69,9 +69,9 @@ if command -v $c >/dev/null 2>&1 ; then
>  	# compile the general v8a also for clang to increase coverage
>  	export CC=3D"ccache clang"
>  	build build-arm64-host-clang $use_shared \
> -		--cross-file config/arm/arm64_armv8_linux_gcc
> +		--cross-file $srcdir/config/arm/arm64_armv8_linux_gcc
> =20
> -	for f in config/arm/arm*gcc ; do
> +	for f in $srcdir/config/arm/arm*gcc ; do
>  		export CC=3D"ccache gcc"
>  		build build-$(basename $f | tr '_' '-' | cut -d'-' -f-
> 2) \
>  			$use_shared --cross-file $f
>=20

Acked-by: Luca Boccassi <bluca@debian.org>

--=20
Kind regards,
Luca Boccassi