From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 2/3] lpm: add support for NEON
Date: Thu, 11 Feb 2016 12:46:33 +0100
Message-ID: <8996069.HySAWEmhf4@xps13>
References: <1449242086-19051-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1454040645-23864-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1454040645-23864-3-git-send-email-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, viktorin@rehivetech.com
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, konstantin.ananyev@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 7EAEF214A
 for <dev@dpdk.org>; Thu, 11 Feb 2016 12:48:01 +0100 (CET)
Received: by mail-wm0-f46.google.com with SMTP id p63so64697788wmp.1
 for <dev@dpdk.org>; Thu, 11 Feb 2016 03:48:01 -0800 (PST)
In-Reply-To: <1454040645-23864-3-git-send-email-jerin.jacob@caviumnetworks.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-01-29 09:40, Jerin Jacob:
> --- a/app/test/test_xmmt_ops.h
> +++ b/app/test/test_xmmt_ops.h
> +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64)
[...]
> +#else
[...]
> --- a/lib/librte_lpm/Makefile
> +++ b/lib/librte_lpm/Makefile
> +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),)
> +SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_neon.h
> +else
>  SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_sse.h
> +endif
[...]
> --- a/lib/librte_lpm/rte_lpm.h
> +++ b/lib/librte_lpm/rte_lpm.h
> +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64)
> +#include "rte_lpm_neon.h"
> +#else
>  #include "rte_lpm_sse.h"
> +#endif

Instead of defaulting to x86 SSE, it would be better to replace
"else" by "elif X86/SSE".
I suggest using RTE_ARCH_X86 or RTE_CPUFLAG_SSEx.
By the way, what is the minimum SSE version required?