From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v7 08/15] net/ixgbe: use rte_eth_linkstatus
 functions
Date: Thu, 25 Jan 2018 13:45:53 +0000
Message-ID: <89c33483-d9c0-a07e-53af-fdd1de1886e1@intel.com>
References: <20180122235458.28562-1-stephen@networkplumber.org>
 <20180122235458.28562-9-stephen@networkplumber.org>
 <20180123122706.GB22398@hmswarspite.think-freely.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Neil Horman <nhorman@tuxdriver.com>,
 Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 570241B00C
 for <dev@dpdk.org>; Thu, 25 Jan 2018 14:45:56 +0100 (CET)
In-Reply-To: <20180123122706.GB22398@hmswarspite.think-freely.org>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/23/2018 12:27 PM, Neil Horman wrote:
> On Mon, Jan 22, 2018 at 03:54:51PM -0800, Stephen Hemminger wrote:
>> Use the new helper functions from eth_dev for
>> handling atomic link_info update.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>
>> ---
>>  drivers/net/ixgbe/ixgbe_ethdev.c | 96 +++++++---------------------------------
>>  1 file changed, 17 insertions(+), 79 deletions(-)
>>
>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
>> index 58217680c29c..7b74cbe92c0d 100644
>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>> @@ -20,7 +20,6 @@
>>  #include <rte_debug.h>
>>  #include <rte_pci.h>
>>  #include <rte_bus_pci.h>
>> -#include <rte_atomic.h>
>>  #include <rte_branch_prediction.h>
>>  #include <rte_memory.h>
>>  #include <rte_eal.h>
>> @@ -787,58 +786,6 @@ static const struct rte_ixgbe_xstats_name_off rte_ixgbevf_stats_strings[] = {
>>  #define IXGBEVF_NB_XSTATS (sizeof(rte_ixgbevf_stats_strings) /	\
>>  		sizeof(rte_ixgbevf_stats_strings[0]))
>>  
> Getting some build errors here:
> 
> CC igb_ethdev.o
> /home/nhorman/git/dpdk/drivers/net/e1000/igb_ethdev.c: In function ‘eth_igb_stop’:
> /home/nhorman/git/dpdk/drivers/net/e1000/igb_ethdev.c:1510:2: error: implicit declaration of function ‘rte_eth_linkstatus_set’; did you mean ‘rte_eth_xstats_get’? [-Werror=implicit-function-declaration]
>   rte_eth_linkstatus_set(dev, &link);
>   ^~~~~~~~~~~~~~~~~~~~~~
>   rte_eth_xstats_get
> /home/nhorman/git/dpdk/drivers/net/e1000/igb_ethdev.c:1510:2: error: nested extern declaration of ‘rte_eth_linkstatus_set’ [-Werror=nested-externs]
> /home/nhorman/git/dpdk/drivers/net/e1000/igb_ethdev.c: In function ‘eth_igb_interrupt_action’:
> /home/nhorman/git/dpdk/drivers/net/e1000/igb_ethdev.c:2831:3: error: implicit declaration of function ‘rte_eth_linkstatus_get’; did you mean ‘rte_eth_xstats_get’? [-Werror=implicit-function-declaration]
>    rte_eth_linkstatus_get(dev, &link);
> 

Compiles fine for me, any change that you are using old version of dpdk that
driver doesn't use rte_ethdev_driver.h yet which these functions are implemented in?