From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v5 3/5] bus: introduce new log type for bus
	drivers
Date: Wed, 11 Oct 2017 16:50:54 +0530
Message-ID: <89d68ff6-9eca-185f-c7c0-8aaaf9e514b0@nxp.com>
References: <1507519229-80692-1-git-send-email-jianfeng.tan@intel.com>
 <1507548444-33959-1-git-send-email-jianfeng.tan@intel.com>
 <1507548444-33959-4-git-send-email-jianfeng.tan@intel.com>
 <7732f195-64fd-308c-8faf-c1b0e37d3453@nxp.com>
 <4883d822-9aa0-4b88-048c-35d7e9da9c1c@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Cc: <dev@dpdk.org>, <jblunck@infradead.org>, <bruce.richardson@intel.com>,
 <konstantin.ananyev@intel.com>, <pablo.de.lara.guarch@intel.com>,
 <thomas@monjalon.net>, <yliu@fridaylinux.org>, <maxime.coquelin@redhat.com>,
 <mtetsuyah@gmail.com>, <ferruh.yigit@intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-CY1-obe.outbound.protection.outlook.com
 (mail-cys01nam02on0049.outbound.protection.outlook.com [104.47.37.49])
 by dpdk.org (Postfix) with ESMTP id E73A31B1C3
 for <dev@dpdk.org>; Wed, 11 Oct 2017 13:08:53 +0200 (CEST)
In-Reply-To: <4883d822-9aa0-4b88-048c-35d7e9da9c1c@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wednesday 11 October 2017 04:12 PM, Tan, Jianfeng wrote:
> 
> 
> On 10/11/2017 2:54 PM, Shreyansh Jain wrote:
>> Hello Jianfeng,
>>
>> On Monday 09 October 2017 04:57 PM, Jianfeng Tan wrote:
>>>
> [...]
>>> -#define PMD_DRV_LOG(level, fmt, args...) \
>>> -    PMD_DRV_LOG_RAW(level, fmt "\n", ## args)
>>> +#define FSLMC_VFIO_LOG(level, fmt, args...) \
>>> +    RTE_LOG(level, EAL, "%s(): " fmt "\n", __func__, ##args)
>>
>> This change breaks the FSLMC bus driver. There are macros like 
>> PMD_DRV_LOG which are still in use in the code.
>> Before removing the above, those would have to be restructured.
> 
> Just try to change all PMD_DRV_LOG in fslmc to FSLMC_VFIO_LOG. As you 
> are working on that, I will drop it. >
>>
>> I am already working on converting this logging into dynamic logging.
>> Can you skip this work until then? Does it block your work?
> 
> Do you mean you are working on introducing a new log type for bus drivers?

A dynamic log type using rte_log_register. So, "bus.fslmc", "net.dpaa2" 
and so on. I am not introducing LOGTYPE_BUS.

In past [1], I sent a patch for LOGTYPE_BUS but at that time I 
understood that dynamic logging is the preferred way.

[1] http://dpdk.org/dev/patchwork/patch/24478/


> 
> Thanks,
> Jianfeng
>