From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-stable] [PATCH] ethdev: fix errno to have
 positive value
Date: Wed, 23 Jan 2019 11:49:11 +0000
Message-ID: <8a15117c-9cf4-2736-655b-7852538d265e@intel.com>
References: <1548087515-18823-1-git-send-email-arybchenko@solarflare.com>
 <5358053.gQHV9Io9Z3@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: stable@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>,
 Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <5358053.gQHV9Io9Z3@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 22-Jan-19 4:03 PM, Thomas Monjalon wrote:
> 21/01/2019 17:18, Andrew Rybchenko:
>> rte_errno should be set to positive value from errno.h plus
>> few RTE-specific values.
>>
>> Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
>> Fixes: 439a90b5f2a7 ("ethdev: reorder inline functions")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> 
> Applied, thanks
> 
> There are other occurrences in drivers:
> 	git grep 'rte_errno = -E'
> 

There could also possibly be rte_errno = -value; type assignments. I 
imagine most of them are correct (since the value itself was negative in 
the first place, so additional '-' flips the sign again), but it doesn't 
hurt to check :)

-- 
Thanks,
Anatoly