From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2 1/2] net/tap: calculate checksums of multi segs packets Date: Thu, 31 May 2018 14:54:11 +0100 Message-ID: <8a6c3017-d004-6870-b931-6bb9fbef6a45@intel.com> References: <1523313192-18048-3-git-send-email-ophirmu@mellanox.com> <1524396611-22391-1-git-send-email-ophirmu@mellanox.com> <1524396611-22391-2-git-send-email-ophirmu@mellanox.com> <926c368b-a2ab-6061-f3b8-f58d53d08b33@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Thomas Monjalon , Olga Shern To: Ophir Munk , dev@dpdk.org, Pascal Mazon Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 4318056A3 for ; Thu, 31 May 2018 15:54:14 +0200 (CEST) In-Reply-To: <926c368b-a2ab-6061-f3b8-f58d53d08b33@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/31/2018 2:52 PM, Ferruh Yigit wrote: > On 4/22/2018 12:30 PM, Ophir Munk wrote: >> Prior to this commit IP/UDP/TCP checksum offload calculations >> were skipped in case of a multi segments packet. >> This commit enables TAP checksum calculations for multi segments >> packets. >> The only restriction is that the first segment must contain >> headers of layers 3 (IP) and 4 (UDP or TCP) >> >> Signed-off-by: Ophir Munk > > Hi Ophir, > > Can you please rebase the patch on top of latest master, it doesn't applies cleanly. > > This is an feature from previous release, please send updates early so that we > can get this early into this release. Opps, I replied to v2 instead of v3. But tested latest version, v3, and need v4.