From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v3] bus/vdev: replace device list lock by a
	recursive one
Date: Tue, 22 May 2018 14:34:49 +0100
Message-ID: <8ac95032-f1e3-d762-2cf5-803ad78bb2bb@intel.com>
References: <2833093.uzJjkH71XI@xps>
 <20180522113727.3116-1-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: matan@mellanox.com, ferruh.yigit@intel.com, gaetan.rivet@6wind.com
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 2C2382BD8
 for <dev@dpdk.org>; Tue, 22 May 2018 15:34:55 +0200 (CEST)
In-Reply-To: <20180522113727.3116-1-thomas@monjalon.net>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 22-May-18 12:37 PM, Thomas Monjalon wrote:
> A device like failsafe can manage sub-devices.
> When removing such device, it removes its sub-devices
> and try to take the same vdev_device_list_lock.
> It was causing a deadlock because the lock was not recursive.
> 
> Fixes: 35f462839b69 ("bus/vdev: add lock on device list")
> 
> Suggested-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v3: try recursive lock
> WARNING: not yet tested!
> ---

LGTM

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly