From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] igb_uio: convert license headers to SPDX tags
Date: Mon, 18 Dec 2017 15:08:06 -0800
Message-ID: <8acb43f9-0399-aacb-2898-b4ec06d546ca@intel.com>
References: <20171218210658.37740-1-ferruh.yigit@intel.com>
 <20171218141317.502efa2f@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 45EF7271
 for <dev@dpdk.org>; Tue, 19 Dec 2017 00:08:08 +0100 (CET)
In-Reply-To: <20171218141317.502efa2f@xeon-e3>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/18/2017 2:13 PM, Stephen Hemminger wrote:
> On Mon, 18 Dec 2017 21:06:58 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
>> diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
>> index a3a98c173..d0e4fd966 100644
>> --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
>> +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
>> @@ -1,25 +1,6 @@
>>  /*-
>> - * GPL LICENSE SUMMARY
>> - *
>> - *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
>> - *
>> - *   This program is free software; you can redistribute it and/or modify
>> - *   it under the terms of version 2 of the GNU General Public License as
>> - *   published by the Free Software Foundation.
>> - *
>> - *   This program is distributed in the hope that it will be useful, but
>> - *   WITHOUT ANY WARRANTY; without even the implied warranty of
>> - *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> - *   General Public License for more details.
>> - *
>> - *   You should have received a copy of the GNU General Public License
>> - *   along with this program; if not, write to the Free Software
>> - *   Foundation, Inc., 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
>> - *   The full GNU General Public License is included in this distribution
>> - *   in the file called LICENSE.GPL.
>> - *
>> - *   Contact Information:
>> - *   Intel Corporation
>> + * SPDX-License-Identifier: GPL-2.0
>> + * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
>>   */
>>  
>>  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> 
> SPDX looks better, and since this is a kernel file it should follow
> the Linux kernel standard.
> 
> // SPDX-License-Identifier: GPL-2.0
> /*
>  * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
>  */

OK, I will update.

Is there any benefit of following Linux kernel standard not only for kernel
modules but for all DPDK files?

> 
> You might also want to do the update of year as well.
>