From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Roger B. Melton" <rmelton@cisco.com>
Subject: Re: [dpdk-stable] [PATCH] net/ixgbe: fix calling null
	function of VF
Date: Wed, 10 May 2017 08:20:20 -0400
Message-ID: <8ad4912d-05d5-fdad-8bb5-a3e414c45738@cisco.com>
References: <1494399602-33955-1-git-send-email-wei.dai@intel.com>
 <a16fd390-4efb-8ddc-244d-1b4bd9313684@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, stable@dpdk.org, Laurent Hardy <laurent.hardy@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Wei Dai <wei.dai@intel.com>,
 wenzhuo.lu@intel.com, konstantin.ananyev@intel.com
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <a16fd390-4efb-8ddc-244d-1b4bd9313684@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 5/10/17 5:50 AM, Ferruh Yigit wrote:
> On 5/10/2017 8:00 AM, Wei Dai wrote:
>> hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not
>> be called directly. It had better be replaced by calling
>> ixgbe_get_media_type( ) to avoid crash.
>>
>> Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Wei Dai <wei.dai@intel.com>
> Hi Roger and Laurent,
>
> This is very close the release, can you please support verifying this
> defect?
>
> An explicit Acked-by and/or Tested-by would help a lot.
>
> Thanks,
> ferruh

Hi Ferruh,

Happy to test it.  I'll get back to you shortly.

Regards,
Roger

>
>
>> ---
>>   drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
>> index ec667d8..ed2baec 100644
>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>> @@ -3799,7 +3799,7 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)
>>   	hw->mac.get_link_status = true;
>>   
>>   	if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) &&
>> -		hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) {
>> +		ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {
>>   		speed = hw->phy.autoneg_advertised;
>>   		if (!speed)
>>   			ixgbe_get_link_capabilities(hw, &speed, &autoneg);
>>
> .
>