From: Raslan Darawsheh <rasland@nvidia.com>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Maayan Kashani <mkashani@nvidia.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH] net/mlx5: fix VXLAN and NVGRE encap in async flow API
Date: Tue, 24 Mar 2026 14:28:32 +0200 [thread overview]
Message-ID: <8bb7a0d8-9e20-43f5-987b-492480512c35@nvidia.com> (raw)
In-Reply-To: <20260319125345.664772-1-dsosnowski@nvidia.com>
Hi,
On 19/03/2026 2:53 PM, Dariusz Sosnowski wrote:
> If masked VXLAN_ENCAP or NVGRE_ENCAP flow action
> was used in actions template, then packets were being
> encapsulated into an empty header (all zeroes)
> instead of a header based on provided item definition.
>
> Offending commit has decoupled translation of VXLAN/NVGRE
> tunnel definition from creation of HW action - previously
> this was done in a single function mlx5_tbl_translate_reformat().
> This was done to adjust HWS flow engine for sync flow API.
> This decoupling has introduced a bug for async flow API.
> Translated packet tunnel headers were not used for creation of masked
> encap action.
> Specifically, mlx5_tbl_translate_reformat() function has properly
> translated tunnel definition to tunnel headers,
> but a result of that was not propagated to
> mlx5_tbl_create_reformat_action().
> As a result, zeroed HW buffer was used in place of real data.
>
> This patch fixes that by moving tunnel header translation out of
> mlx5_tbl_translate_reformat() to dedicated handling for VXLAN/NVGRE
> encap flow actions and ensuring that this data is propagated correctly.
> On top of that, translation code for VXLAN/NVGRE is unified
> (it is functionally similar) to reduce code duplication.
>
> Fixes: 9bbe38744a57 ("net/mlx5: set encap as shared flow action")
> Cc: mkashani@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Acked-by: Bing Zhao <bingz@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
prev parent reply other threads:[~2026-03-24 12:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 12:53 [PATCH] net/mlx5: fix VXLAN and NVGRE encap in async flow API Dariusz Sosnowski
2026-03-24 12:28 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bb7a0d8-9e20-43f5-987b-492480512c35@nvidia.com \
--to=rasland@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=mkashani@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox