[PATCH] test/eal: remove PCI probing for vdev tests

[PATCH] test/eal: remove PCI probing for vdev tests

[David Marchand]

Similarly to commit f67f76e6bbfd ("test/eal: remove PCI probing for
recursive calls"), let's disable PCI probing in vdev tests as it
triggers false positive failures in GHA.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/test/test_eal_flags.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index bebddf1c98..06a605cce1 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -422,17 +422,17 @@ test_invalid_vdev_flag(void)
 
 	/* Test with invalid vdev option */
 	const char *vdevinval[] = {prgname, prefix, no_huge, eal_debug_logs,
-				bus_debug_logs, vdev, "eth_dummy"};
+				bus_debug_logs, no_pci, vdev, "eth_dummy"};
 
 	/* Test with valid vdev option */
 	const char *vdevval1[] = {prgname, prefix, no_huge, eal_debug_logs,
-				bus_debug_logs,	vdev, "net_ring0"};
+				bus_debug_logs,	no_pci, vdev, "net_ring0"};
 
 	const char *vdevval2[] = {prgname, prefix, no_huge, eal_debug_logs,
-				bus_debug_logs, vdev, "net_ring0,args=test"};
+				bus_debug_logs, no_pci, vdev, "net_ring0,args=test"};
 
 	const char *vdevval3[] = {prgname, prefix, no_huge, eal_debug_logs,
-				bus_debug_logs, vdev, "net_ring0,nodeaction=r1:0:CREATE"};
+				bus_debug_logs, no_pci, vdev, "net_ring0,nodeaction=r1:0:CREATE"};
 
 	if (launch_proc(vdevinval) == 0) {
 		printf("Error (line %d) - process did run ok with invalid vdev parameter\n",
-- 
2.53.0

Re: [PATCH] test/eal: remove PCI probing for vdev tests

[Bruce Richardson]

On Mon, Feb 23, 2026 at 04:56:03PM +0100, David Marchand wrote:
> Similarly to commit f67f76e6bbfd ("test/eal: remove PCI probing for
> recursive calls"), let's disable PCI probing in vdev tests as it
> triggers false positive failures in GHA.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  app/test/test_eal_flags.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
> index bebddf1c98..06a605cce1 100644
> --- a/app/test/test_eal_flags.c
> +++ b/app/test/test_eal_flags.c
> @@ -422,17 +422,17 @@ test_invalid_vdev_flag(void)
>  
>  	/* Test with invalid vdev option */
>  	const char *vdevinval[] = {prgname, prefix, no_huge, eal_debug_logs,
> -				bus_debug_logs, vdev, "eth_dummy"};
> +				bus_debug_logs, no_pci, vdev, "eth_dummy"};
>  
>  	/* Test with valid vdev option */
>  	const char *vdevval1[] = {prgname, prefix, no_huge, eal_debug_logs,
> -				bus_debug_logs,	vdev, "net_ring0"};
> +				bus_debug_logs,	no_pci, vdev, "net_ring0"};
>  
>  	const char *vdevval2[] = {prgname, prefix, no_huge, eal_debug_logs,
> -				bus_debug_logs, vdev, "net_ring0,args=test"};
> +				bus_debug_logs, no_pci, vdev, "net_ring0,args=test"};
>  
>  	const char *vdevval3[] = {prgname, prefix, no_huge, eal_debug_logs,
> -				bus_debug_logs, vdev, "net_ring0,nodeaction=r1:0:CREATE"};
> +				bus_debug_logs, no_pci, vdev, "net_ring0,nodeaction=r1:0:CREATE"};
>  
>  	if (launch_proc(vdevinval) == 0) {
>  		printf("Error (line %d) - process did run ok with invalid vdev parameter\n",
> -- 
> 2.53.0
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

RE: [PATCH] test/eal: remove PCI probing for vdev tests

[Marat Khalili]

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday 23 February 2026 15:56
> To: dev@dpdk.org
> Cc: bruce.richardson@intel.com
> Subject: [PATCH] test/eal: remove PCI probing for vdev tests
> 
> Similarly to commit f67f76e6bbfd ("test/eal: remove PCI probing for
> recursive calls"), let's disable PCI probing in vdev tests as it
> triggers false positive failures in GHA.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  app/test/test_eal_flags.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
> index bebddf1c98..06a605cce1 100644
> --- a/app/test/test_eal_flags.c
> +++ b/app/test/test_eal_flags.c
> @@ -422,17 +422,17 @@ test_invalid_vdev_flag(void)
> 
>  	/* Test with invalid vdev option */
>  	const char *vdevinval[] = {prgname, prefix, no_huge, eal_debug_logs,
> -				bus_debug_logs, vdev, "eth_dummy"};
> +				bus_debug_logs, no_pci, vdev, "eth_dummy"};
> 
>  	/* Test with valid vdev option */
>  	const char *vdevval1[] = {prgname, prefix, no_huge, eal_debug_logs,
> -				bus_debug_logs,	vdev, "net_ring0"};
> +				bus_debug_logs,	no_pci, vdev, "net_ring0"};

Could use this opportunity to replace tab before no_pci with space.

> 
>  	const char *vdevval2[] = {prgname, prefix, no_huge, eal_debug_logs,
> -				bus_debug_logs, vdev, "net_ring0,args=test"};
> +				bus_debug_logs, no_pci, vdev, "net_ring0,args=test"};
> 
>  	const char *vdevval3[] = {prgname, prefix, no_huge, eal_debug_logs,
> -				bus_debug_logs, vdev, "net_ring0,nodeaction=r1:0:CREATE"};
> +				bus_debug_logs, no_pci, vdev, "net_ring0,nodeaction=r1:0:CREATE"};
> 
>  	if (launch_proc(vdevinval) == 0) {
>  		printf("Error (line %d) - process did run ok with invalid vdev parameter\n",
> --
> 2.53.0

Acked-by: Marat Khalili <marat.khalili@huawei.com>
Tested-by: Marat Khalili <marat.khalili@huawei.com>

Definitely not a problem of this patch, but creating a separate define for each command-line argument like --no-huge does nothing to save us from repeating `prgname, prefix, eal_debug_logs, ...` bazillion times. If tokens are burning a hole in someone's pocket, perhaps instead we could move this whole command prefix into some kind of function or macro with parameters (possibly one launching subprocess as well).

Another thought, should we have NOPCI_OK/NOPCI_SKIP similar to ASAN and NOHUGE?

Re: [PATCH] test/eal: remove PCI probing for vdev tests

[David Marchand]

On Mon, 23 Feb 2026 at 18:16, Marat Khalili <marat.khalili@huawei.com> wrote:
> > @@ -422,17 +422,17 @@ test_invalid_vdev_flag(void)
> >
> >       /* Test with invalid vdev option */
> >       const char *vdevinval[] = {prgname, prefix, no_huge, eal_debug_logs,
> > -                             bus_debug_logs, vdev, "eth_dummy"};
> > +                             bus_debug_logs, no_pci, vdev, "eth_dummy"};
> >
> >       /* Test with valid vdev option */
> >       const char *vdevval1[] = {prgname, prefix, no_huge, eal_debug_logs,
> > -                             bus_debug_logs, vdev, "net_ring0"};
> > +                             bus_debug_logs, no_pci, vdev, "net_ring0"};
>
> Could use this opportunity to replace tab before no_pci with space.

Oh yes, good catch.

>
> >
> >       const char *vdevval2[] = {prgname, prefix, no_huge, eal_debug_logs,
> > -                             bus_debug_logs, vdev, "net_ring0,args=test"};
> > +                             bus_debug_logs, no_pci, vdev, "net_ring0,args=test"};
> >
> >       const char *vdevval3[] = {prgname, prefix, no_huge, eal_debug_logs,
> > -                             bus_debug_logs, vdev, "net_ring0,nodeaction=r1:0:CREATE"};
> > +                             bus_debug_logs, no_pci, vdev, "net_ring0,nodeaction=r1:0:CREATE"};
> >
> >       if (launch_proc(vdevinval) == 0) {
> >               printf("Error (line %d) - process did run ok with invalid vdev parameter\n",
> > --
> > 2.53.0
>
> Acked-by: Marat Khalili <marat.khalili@huawei.com>
> Tested-by: Marat Khalili <marat.khalili@huawei.com>
>
> Definitely not a problem of this patch, but creating a separate define for each command-line argument like --no-huge does nothing to save us from repeating `prgname, prefix, eal_debug_logs, ...` bazillion times. If tokens are burning a hole in someone's pocket, perhaps instead we could move this whole command prefix into some kind of function or macro with parameters (possibly one launching subprocess as well).
>
> Another thought, should we have NOPCI_OK/NOPCI_SKIP similar to ASAN and NOHUGE?

It would be simpler to always disable pci and keep it enabled for
those tests that do require it.
I wonder what unit tests do require PCI in the fast-tests suite...
probably really few.


-- 
David Marchand

Re: [PATCH] test/eal: remove PCI probing for vdev tests

[David Marchand]

On Mon, 23 Feb 2026 at 16:56, David Marchand <david.marchand@redhat.com> wrote:
>
> Similarly to commit f67f76e6bbfd ("test/eal: remove PCI probing for
> recursive calls"), let's disable PCI probing in vdev tests as it
> triggers false positive failures in GHA.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.


-- 
David Marchand