From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 1/5] eal: Set numa node value for system
 which not support NUMA.
Date: Thu, 5 Jan 2017 14:23:57 +0000
Message-ID: <8cb35df0-cdd6-143c-4f78-379a89f44616@intel.com>
References: <1483617709-7088-1-git-send-email-nic@opencloud.tech>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
To: nickcooper-zhangtonghao <nic@opencloud.tech>, dev@dpdk.org,
 Yong Wang <yongwang@vmware.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 6460E2946
 for <dev@dpdk.org>; Thu,  5 Jan 2017 15:24:00 +0100 (CET)
In-Reply-To: <1483617709-7088-1-git-send-email-nic@opencloud.tech>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/5/2017 12:01 PM, nickcooper-zhangtonghao wrote:
> The NUMA node information for PCI devices provided through
> sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx
> on Red Hat Enterprise Linux 6, and VMs on some hypervisors.
> 
> Signed-off-by: nickcooper-zhangtonghao <nic@opencloud.tech>

Hi nickcooper-zhangtonghao,

The patches in the patchset are individual patches, right? Is there any
dependency between them?

And CC'ed vmxnet3 driver maintainer: Yong Wang <yongwang@vmware.com>

Thanks,
ferruh

> ---
>  lib/librte_eal/linuxapp/eal/eal_pci.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
> index 4350134..5dfdbe9 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
> @@ -317,7 +317,13 @@
>  			free(dev);
>  			return -1;
>  		}
> -		dev->device.numa_node = tmp;
> +		/* The NUMA node information for PCI devices provided through
> +		 * sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx
> +		 * on Red Hat Enterprise Linux 6, and VMs on some hypervisors.
> +		 * In the upstream linux kernel, the numa_node is an integer,
> +		 * which data type is int, not unsigned long.
> +		 */
> +		dev->device.numa_node = (int)tmp > 0 ? (int)tmp : 0;
>  	}
>  
>  	/* parse resources */
>