From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: DEV_RX_OFFLOAD_SCATTER for ixgbe and igb devices
Date: Fri, 13 Apr 2018 18:16:07 +0100
Message-ID: <8daedfce-bf0a-87f4-c219-f0f0cb64deb5@intel.com>
References: <CD7C01071941AC429549C17338DB8A5289214FDC@IRSMSX101.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Qi Zhang <qi.z.zhang@intel.com>, Helin Zhang <helin.zhang@intel.com>
To: "Stokes, Ian" <ian.stokes@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 9A92D1C6D9
 for <dev@dpdk.org>; Fri, 13 Apr 2018 19:16:10 +0200 (CEST)
In-Reply-To: <CD7C01071941AC429549C17338DB8A5289214FDC@IRSMSX101.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/13/2018 3:52 PM, Stokes, Ian wrote:
> Hi all,
> 
> Currently it's the case that for some NICs (e.g. igb driver or ixgbe driver based), scatter_rx needs to be enabled explicitly in the case where it was not configured before.
> 
> A patch submitted for ovs-dpdk proposes to check that the DEV_RX_OFFLOAD_SCATTER flag is present in rte_ethdev_info.rx_offload_capa before setting scatter_rx.
> 
> https://mail.openvswitch.org/pipermail/ovs-dev/2018-April/345901.html
> 
> While testing igb and ixgbe devices I spotted the DEV_RX_OFFLOAD_SCATTER flag is not set in rx_offload_capa.
> 
> As these devices require scatter_rx, should the scatter_rx flag be set for them as part of the eth_igb_infos_get() for igb and ixgbe_dev_info_get for ixgbe?

I agree, since that offload is supported by PMD, should be in capability flag.
Would you mind sending a patch for it, we can continue to discuss on it?

Thanks,
ferruh