From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v4 2/4] app/testpmd: extend fwd statistics to 64bits Date: Fri, 22 Mar 2019 18:06:14 +0100 Message-ID: <8de1b82d-29a8-10be-75b1-463c9d755c19@redhat.com> References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-3-git-send-email-david.marchand@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, ramirose@gmail.com, arybchenko@solarflare.com, ferruh.yigit@intel.com, stable@dpdk.org To: David Marchand , dev@dpdk.org Return-path: In-Reply-To: <1553261824-1881-3-git-send-email-david.marchand@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/22/19 2:37 PM, David Marchand wrote: > fwd engine statistics are stored as unsigned int (32bits) and can wrap > quite quickly. > Example: sending 7mpps for 614s gives us 4298000000 packets => > 0x1002e4680 larger than 32bits. > > testpmd reports forwarding stats as: > RX-packets: 3500381 TX-packets: 3500010 TX-dropped: 371 > > While the port and accumulated stats are reported as 64bits: > RX-packets: 4298467677 RX-dropped: 0 RX-total: 4298467677 > TX-packets: 4298467306 TX-dropped: 371 TX-total: 4298467677 > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > Reviewed-by: Andrew Rybchenko > --- > Changelog since v2: > - split out of the previous patch with a dedicated commitlog > - Cc'd stable > > --- > app/test-pmd/testpmd.c | 51 +++++++++++++++++--------------------------------- > app/test-pmd/testpmd.h | 12 ++++++------ > 2 files changed, 23 insertions(+), 40 deletions(-) > Reviewed-by: Maxime Coquelin