From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hunt, David" Subject: Re: [PATCH v1 5/7] examples/power: add json string handling Date: Wed, 12 Sep 2018 11:54:54 +0100 Message-ID: <8e4465cd-6eb5-7664-b945-400b130cde74@intel.com> References: <20180830105422.1198-1-david.hunt@intel.com> <20180830105422.1198-6-david.hunt@intel.com> <20180830100100.7ddf8630@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, john.mcnamara@intel.com To: Stephen Hemminger Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 7967C4C92 for ; Wed, 12 Sep 2018 12:55:19 +0200 (CEST) In-Reply-To: <20180830100100.7ddf8630@xeon-e3> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen, On 30/8/2018 6:00 PM, Stephen Hemminger wrote: > On Thu, 30 Aug 2018 11:54:20 +0100 > David Hunt wrote: > >> Add JSON string handling to vm_power_manager for JSON strings received >> through the fifo. The format of the JSON strings are detailed in the >> next patch, the vm_power_manager user guide documentation updates. >> >> This patch introduces a new dependency on Jansson, a C library for >> encoding, decoding and manipulating JSON data. To compile the sample app >> you now need to have installed libjansson4 and libjansson-dev (these may >> be named slightly differently depending on your Operating System) >> >> Signed-off-by: David Hunt > If you introduce new dependency then it has to be in documentation, > and off by default in Makefile, and checked in meson build. Sure, I've added a check in the Makefile for the existence of the library, and it will build in the JSON handling if present, otherwise warn the user and build without. Thanks, Dave.