From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v4 0/4] Enable hotplug in vfio Date: Thu, 4 Oct 2018 10:11:22 +0100 Message-ID: <8e44ad47-133f-8e20-6600-df0df3ac8682@intel.com> References: <1534503091-31910-1-git-send-email-jia.guo@intel.com> <1538635483-92222-1-git-send-email-jia.guo@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org, helin.zhang@intel.com, jerin.jacob@caviumnetworks.com To: Jeff Guo , stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net, motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com, arybchenko@solarflare.com Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id CBF607CDE for ; Thu, 4 Oct 2018 11:11:58 +0200 (CEST) In-Reply-To: <1538635483-92222-1-git-send-email-jia.guo@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04-Oct-18 7:44 AM, Jeff Guo wrote: > As we may know that the process of hotplug is different between igb_uio > and vfio. For igb_uio, it could use uevent notification and memory > failure handle mechanism for hot-unplug. But for vfio, when device is be > hot-unplugged, the uevent can not be detected immediately, because of the > vfio kernel module will use a special mechanism to guaranty the pci > device would not be deleted until the user space release the resources, > so it will use another req notifier event at first to notify user space > to release resources for hotplug. > > This patch will add a new interrupt type of req notifier in eal interrupt, > and add the new interrupt handler in pci device to handle the req device > event. When the req notifier be detected, it can trigger the device event > callback process to process for hot-unplug. With this mechanism, hotplug > could be enable in vfio. > LGTM Acked-by: Anatoly Burakov -- Thanks, Anatoly