From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 15/31] net/i40e/base: add FEC bits to PHY capabilities Date: Mon, 5 Dec 2016 14:30:42 +0000 Message-ID: <8e46037c-83d2-e4e9-9916-9a98382788d4@intel.com> References: <1480727953-92137-1-git-send-email-jingjing.wu@intel.com> <1480727953-92137-16-git-send-email-jingjing.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: helin.zhang@intel.com To: Jingjing Wu , dev@dpdk.org Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C4E442BDD for ; Mon, 5 Dec 2016 15:30:58 +0100 (CET) In-Reply-To: <1480727953-92137-16-git-send-email-jingjing.wu@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jingjing, On 12/3/2016 1:18 AM, Jingjing Wu wrote: > Add FEC bits to the PHY capabilities AQ command struct. This is required > for 25GbE support. Change the name of the generic mod_type_ext field to > indicate that it is now used for handling FEC. > > Signed-off-by: Jingjing Wu > --- > drivers/net/i40e/base/i40e_adminq_cmd.h | 13 ++++++++++++- > drivers/net/i40e/base/i40e_common.c | 2 ++ > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h > index 4f06772..1884758 100644 > --- a/drivers/net/i40e/base/i40e_adminq_cmd.h > +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h > @@ -1785,7 +1785,16 @@ struct i40e_aq_get_phy_abilities_resp { > #define I40E_AQ_PHY_TYPE_EXT_25G_CR 0X02 > #define I40E_AQ_PHY_TYPE_EXT_25G_SR 0x04 > #define I40E_AQ_PHY_TYPE_EXT_25G_LR 0x08 > - u8 mod_type_ext; > + u8 fec_cfg_curr_mod_ext_info; This is causing a compilation error in next-net [1] after Qi's patch for 25G auto link enable patch: http://dpdk.org/dev/patchwork/patch/17338/ Can you please rebase the patchset on top op next-net ? Thanks, ferruh [1] .../drivers/net/i40e/i40e_ethdev.c: In function ‘i40e_phy_conf_link’: .../drivers/net/i40e/i40e_ethdev.c:1632:30: error: ‘struct i40e_aq_get_phy_abilities_resp’ has no member named ‘mod_type_ext’; did you mean ‘phy_type_ext’? phy_conf.fec_config = phy_ab.mod_type_ext; ^