From mboxrd@z Thu Jan 1 00:00:00 1970 From: Remy Horton Subject: Re: rte_ether: Driver-specific stats getting overwritten Date: Thu, 14 Jul 2016 16:50:40 +0100 Message-ID: <8f3d7b0d-6b74-ec2e-94d3-075f1c055bac@intel.com> References: <1195a38d-8615-03d2-22eb-04f6b071d38b@intel.com> <1954062.51W9tGj6hj@xps13> <04EE3350-421C-47F9-9D6F-A1D4992FD932@nfware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: Igor Ryzhov , Thomas Monjalon Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0BCFBF94 for ; Thu, 14 Jul 2016 17:50:42 +0200 (CEST) In-Reply-To: <04EE3350-421C-47F9-9D6F-A1D4992FD932@nfware.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 14/07/2016 14:51, Igor Ryzhov wrote: [..] > How about deleting rx_nombuf from rte_eth_stats? Do you think this > counter is necessary? It just shows enormous numbers in case of a > lack of processing speed. But we already have imissed counter which > shows real number of packets, dropped for the same reason. Deleting it has API/ABI breakage issues. There is also lack of=20 consistency between drivers as to what imissed includes, as some don't=20 implement it at all whereas others include filtered packets as well. >> 14 =D0=B8=D1=8E=D0=BB=D1=8F 2016 =D0=B3., =D0=B2 16:37, Thomas Monjalo= n >> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB= (=D0=B0): >> [..] >> Yes it is strange and has always been like that. Why not moving the >> assignment before calling the driver callback? Think I'll do that. Easier than updating all the drivers that don't fill=20 it in..