From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH 7/7] eal: improve musl compatibility Date: Wed, 29 Aug 2018 15:09:47 +0100 Message-ID: <8f3e6994-f509-c885-7f3c-6e791d04dee3@intel.com> References: <4f7ac27b4fe1561fd3e3358a89f89ce025a7a128.1535543250.git.anatoly.burakov@intel.com> <20180829123926.GB39260@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, dpdk@stormmq.com To: Bruce Richardson Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 980782B92 for ; Wed, 29 Aug 2018 16:09:54 +0200 (CEST) In-Reply-To: <20180829123926.GB39260@bricha3-MOBL.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 29-Aug-18 1:39 PM, Bruce Richardson wrote: > On Wed, Aug 29, 2018 at 12:56:21PM +0100, Anatoly Burakov wrote: >> Musl complains about pthread id being of wrong size. Fix it by >> casting to 64-bit and printing 64-bit hex unconditionally. >> >> Signed-off-by: Anatoly Burakov >> --- > Given that on linux pthread_t is a pointer type, will this not give other > warnings of casting from pointer to integer of a different type when > compiling 32-bit? For safety I suggest casting to long or uintptr_t > instead, to ensure we always get an int of the right size. > > /Bruce > Sure, will fix. -- Thanks, Anatoly