From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v4 00/22] net/atlantic: Aquantia aQtion 10G NIC Family DPDK PMD driver Date: Wed, 10 Oct 2018 11:32:37 +0100 Message-ID: <8f55ed2f-11cd-4e81-b7c1-96e82da12d6d@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Pavel Belous To: Igor Russkikh , "dev@dpdk.org" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6E6571B56F for ; Wed, 10 Oct 2018 12:32:39 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/9/2018 10:31 AM, Igor Russkikh wrote: > Hello DPDK community! > > Aquantia would like to contribute PMD for aQtion AQC10X NIC family: > https://www.aquantia.com/products/aqtion/chips/ > These are 10G ethernet NICs with various features. > > We do base this work on parts of the existing native linux kernel > driver source (atlantic). Shared code is hw_atl hardware and registers access module. > > We'd like to target this driver for 18.11 DPDK release timeline, > it'd be good to hear comments from the community on how feasible is this. > > This patchset implements basic driver infrastructure, > vlan offloads, checksumm offloads, rss control, > multiring, jumbo frames and other features. > > Later on, we plan to share HW MACSEC offloads, rxflows and other features. > > version 4 changes: > - fixed build errors with -Werror on gcc7 > - validated build on arm64, freebsd x86_64 > - PPC marked as unsupported arch > - stdbool.h is used instead of bool redefines > > version 3 changes: > - patchset fixed to be incrementally buildable > - extra includes removed and cleaned up > - license changed to dual GPL-BSD for pieces shared with linux > - removed extra logging #defines > - misc comments from previous review session > > version 2 changes: > - fixed build on freebsd (no ETIME const) > - fixed a bunch of checkpatch failures and warnings > - removed extra CFLAGS disabled warning > - making static arrays const > > > Igor Russkikh (9): > net/atlantic: logging macroes and some typedefs > net/atlantic: hardware register access routines > net/atlantic: hw_atl register declarations > net/atlantic: firmware operations layer > net/atlantic: b0 hardware layer main logic > net/atlantic: RX side structures and implementation > net/atlantic: RSS and RETA manipulation API > net/atlantic: LED control DPDK and private APIs > net/atlantic: documentation and rel notes > > Pavel Belous (13): > net/atlantic: atlantic PMD driver skeleton > net/atlantic: rte device start, stop, initial configuration > net/atlantic: TX/RX function prototypes > net/atlantic: TX side structures and implementation > net/atlantic: link status and interrupt management > net/atlantic: device statistics, xstats > net/atlantic: support for RX/TX descriptors information > net/atlantic: promisc and allmulti configuration > net/atlantic: flow control configuration > net/atlantic: MAC address manipulations > net/atlantic: VLAN filters and offloads > net/atlantic: eeprom and register manipulation routines > net/atlantic: support for read MAC registers for debug purposes Hi Igor, I put some comments on individual patches, please check them. Also can you please run "./devtools/check-git-log.sh -22" and fix reported warnings there? Thanks, ferruh