From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 558F0C432BE for ; Sun, 29 Aug 2021 11:18:51 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id D5AAE60E90 for ; Sun, 29 Aug 2021 11:18:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D5AAE60E90 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A55040142; Sun, 29 Aug 2021 13:18:50 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id CC5E540042 for ; Sun, 29 Aug 2021 13:18:47 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10090"; a="240382670" X-IronPort-AV: E=Sophos;i="5.84,361,1620716400"; d="scan'208";a="240382670" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2021 04:18:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,361,1620716400"; d="scan'208";a="576528549" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 29 Aug 2021 04:18:46 -0700 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 29 Aug 2021 04:18:45 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 29 Aug 2021 19:18:38 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.010; Sun, 29 Aug 2021 19:18:37 +0800 From: "Zhang, Qi Z" To: "Wu, Wenjun1" , "dev@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" CC: "Wu, Wenjun1" Thread-Topic: [dpdk-dev] [PATCH v2] net/iavf: fix wrong FDIR L3 field set for IPv4 fragment packets Thread-Index: AQHXkzaw1GyQ4MPxvU2Bd61f2+CDLquKaKwQ Date: Sun, 29 Aug 2021 11:18:37 +0000 Message-ID: <8ff1fc48ee804acc9350cad327db1dfc@intel.com> References: <20210802075754.952979-1-wenjun1.wu@intel.com> <20210817064955.160102-1-wenjun1.wu@intel.com> In-Reply-To: <20210817064955.160102-1-wenjun1.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/iavf: fix wrong FDIR L3 field set for IPv4 fragment packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Wenjun Wu > Sent: Tuesday, August 17, 2021 2:50 PM > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Cc: Wu, Wenjun1 > Subject: [dpdk-dev] [PATCH v2] net/iavf: fix wrong FDIR L3 field set for = IPv4 > fragment packets >=20 > Originally, the value of field_selector for IPV4_FRAG header hdr1 is the = same as > the previous header hdr2. For IPv4 packets, field_selector for hdr2 can b= e any > value between 0 and 4, depending on the selected field. Actually, this va= lue for > IPV4_FRAG should be constant 0, which denotes the field packet ID. >=20 > This patch adds an assignment to hdr1->field_selector to make sure that i= t is > always 0. >=20 > Fixes: 3334513ef484 ("net/iavf: support flow director for IP fragment") >=20 > Signed-off-by: Wenjun Wu Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi