From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] fix build warning and failure in Suse11
Date: Wed, 18 Mar 2015 11:50:30 +0100
Message-ID: <9030243.H2PSOagFNB@xps13>
References: <1426662641-24781-1-git-send-email-yong.liu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Yong Liu <yong.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1426662641-24781-1-git-send-email-yong.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Yong,

Thanks for working on these important fixes.

2015-03-18 15:10, Yong Liu:
> Suse11 SP3 default gcc version is 4.3.4, some options not support on =
this version.

I guess some of these errors are not only specific to Suse-11?
Maybe that 1 patch per issue would be easier to read and could provide =
a more
accurate description.

> error: implicit declaration of function =E2=80=98_mm_alignr_epi8=E2=80=
=99
> solution: include tmmintrin.h when enable SSE3
>=20
> error: unrecognized command line option "-Wno-unused-but-set-variable=
"
> solution: add version check in fm10k Makefile
>=20
> error: enic_main.c:845: error: initialized field overwritten
> solution: change struct initialization code
>=20
> error: =E2=80=98testfn_pci_cmd=E2=80=99 defined but not used
> solution: add __attribute__((unused)) before function definition

Please could you explain more the problem?
There are other constructors in DPDK which don't need the unused attrib=
ute.

>=20
> error: unrecognized command line option "-fno-var-tracking-assignment=
s"
> solution: add version check in app/test/Makefile
>=20
> error: implicit declaration of function =E2=80=98pread=E2=80=99
> solution: add _GNU_SOURCE flag when compile eal_pci_uio and eal_inter=
rupts
>=20
> signed-off-by: Marvin Liu <yong.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Please use -s git option to have an automatic well formatted Signed-off=
.
Your previous contributions were signed "Yong Liu". Do you prefer Marvi=
n Liu?