From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] net/mlx5: only register memory callback when
	probing a device
Date: Wed, 30 May 2018 21:07:10 +0200
Message-ID: <9098846.r4ODMIHPIA@xps>
References: <20180530144253.8935-1-david.marchand@6wind.com>
 <73FA6D64-52F7-4273-971E-6A1579073631@mellanox.com>
 <CALwxeUs3MdZx1X0FpRpriY0U5+xXz2xDc4M4iy4eY3UpTyqYHQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Yongseok Koh <yskoh@mellanox.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 =?ISO-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>,
 Shahaf Shuler <shahafs@mellanox.com>
To: David Marchand <david.marchand@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id DBDE416E
 for <dev@dpdk.org>; Wed, 30 May 2018 21:07:12 +0200 (CEST)
In-Reply-To: <CALwxeUs3MdZx1X0FpRpriY0U5+xXz2xDc4M4iy4eY3UpTyqYHQ@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

30/05/2018 18:04, David Marchand:
> On Wed, May 30, 2018 at 5:59 PM, Yongseok Koh <yskoh@mellanox.com> wrote:
> >> On May 30, 2018, at 7:42 AM, David Marchand <david.marchand@6wind.com> wrote:
> >>
> >> The callback should be invoked only for memory that has been registered
> >> in a device, hence, no need to track cleanup events if no device is
> >> present.
> >>
> >> Bugzilla-ID: 56
> >> Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support")
> >>
> >> Signed-off-by: David Marchand <david.marchand@6wind.com>
> >> ---
> >
> > Good finding! Thank you so much for the patch.
> > Patch is good. Just to be sure, I've run traffic with testpmd and also run
> > multi-process test examples with traffic. It runs well.
> >
> > Acked-by: Yongseok Koh <yskoh@mellanox.com>
> 
> Well, this is a quick fix, the mlx5_prepare_shared_data() now does
> more than initialising the shared data...
> Might be better to revisit later, but this should do the job for 18.05.

Applied, thanks