From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2] devtools: add script to get maintainers from patch Date: Tue, 7 Nov 2017 15:41:43 -0800 Message-ID: <90f53ade-59d0-378d-bdd5-1d82bb6db733@intel.com> References: <20170428163420.25785-1-ferruh.yigit@intel.com> <20170804140125.76823-1-ferruh.yigit@intel.com> <3010398.kuAIiaT0df@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, John McNamara To: Thomas Monjalon Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 1D0CC1B3D1 for ; Wed, 8 Nov 2017 00:41:44 +0100 (CET) In-Reply-To: <3010398.kuAIiaT0df@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/7/2017 3:35 PM, Thomas Monjalon wrote: > 04/08/2017 16:01, Ferruh Yigit: >> This is a wrapper to Linux kernel get_maintainer.pl file and only >> supports parsing MAINTAINERS file (no git fallback etc..) >> >> Requires DPDK_GETMAINTAINER_PATH devel config option set, please check >> devtools/load-devel-config. >> >> DPDK_GETMAINTAINER_PATH should be full path to the get_maintainer.pl >> script, like: >> DPDK_GETMAINTAINER_PATH=~/linux/scripts/get_maintainer.pl >> >> Can be used individually: >> ./devtools/get_maintainer.sh >> >> Or via git send-email, to add maintainers automatically: >> git send-email --to-cmd ./devtools/get_maintainer.sh \ >> --cc dev@dpdk.org HEAD -4 >> >> Currently there is an ugly workaround to be able to use Linux script out >> of the kernel tree, later better method can replace it. >> >> Signed-off-by: Ferruh Yigit > > Sorry for having missed this very convenient patch for months. > > Applied, thanks > > Have you tried to send a patch to Linux > in order to avoid the workaround below? No, not tried, but that list looks like put intentionally so not sure if a patch helps. > >> +FILES="COPYING CREDITS Kbuild" >> +FOLDERS="Documentation arch include fs init ipc kernel scripts" >> + >> +# Kernel script checks for some files and folders to run >> +workaround () { >> + for f in $FILES; do >> + if [ ! -f $f ]; then touch $f; fi >> + done >> + >> + for d in $FOLDERS; do >> + if [ ! -d $d ]; then mkdir $d; fi >> + done >> +}