From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH v2] build: mention machine=default and its
 use in documentation
Date: Wed, 27 Feb 2019 12:16:11 +0000
Message-ID: <913c24a1beca6c41b9ba24641fa151fc76c21c36.camel@debian.org>
References: <20190114112331.15761-1-bluca@debian.org>
 <20190114134106.17383-1-bluca@debian.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com
 [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 1754E5A6E
 for <dev@dpdk.org>; Wed, 27 Feb 2019 13:16:13 +0100 (CET)
Received: by mail-wm1-f68.google.com with SMTP id g20so4618945wmh.5
 for <dev@dpdk.org>; Wed, 27 Feb 2019 04:16:13 -0800 (PST)
Received: from localhost ([2a01:4b00:f419:6f00:b00c:66c8:99df:336])
 by smtp.gmail.com with ESMTPSA id p68sm626538wme.45.2019.02.27.04.16.11
 for <dev@dpdk.org>
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 27 Feb 2019 04:16:11 -0800 (PST)
In-Reply-To: <20190114134106.17383-1-bluca@debian.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 2019-01-14 at 13:41 +0000, Luca Boccassi wrote:
> Document the new value, as it's useful for distributions and users
> who need to use a stable baseline -march
>=20
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
> v2: fix typo, add commit body and reviewed-by
>=20
>  doc/build-sdk-meson.txt | 5 +++++
>  1 file changed, 5 insertions(+)
>=20
> diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt
> index 29a8bd387..ab33ca82a 100644
> --- a/doc/build-sdk-meson.txt
> +++ b/doc/build-sdk-meson.txt
> @@ -87,6 +87,8 @@ Project-specific options are passed used
> -Doption=3Dvalue::
> =20
>  	meson -Denable_docs=3Dtrue fullbuild  # build and install docs
> =20
> +	meson -Dmachine=3Ddefault  # use builder-independent baseline
> -march
> +
>  Examples of setting the same options using meson configure::
> =20
>  	meson configure -Dwerror=3Dtrue
> @@ -103,6 +105,9 @@ should be used to change the build settings
> within the directory, and when
>  ``ninja`` is called to do the build itself, it will trigger the
> necessary
>  re-scan from meson.
> =20
> +NOTE: machine=3Ddefault will use the minimum required -march on all
> architectures
> +regardless of the capabilities of the machine where the build is
> happening.
> +
>  As well as those settings taken from ``meson configure``, other
> options
>  such as the compiler to use can be passed via environment variables.
> For
>  example::

Ping - anything else I can do for this patch? Thanks!

--=20
Kind regards,
Luca Boccassi