From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A597C433DB for ; Thu, 7 Jan 2021 16:43:28 +0000 (UTC) Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id ECEFA23403 for ; Thu, 7 Jan 2021 16:43:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECEFA23403 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A4FC8140F7D; Thu, 7 Jan 2021 17:43:26 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 480C4140F68 for ; Thu, 7 Jan 2021 17:43:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610037805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TIluGvKC1OOuQJoNrYSl3p+4j1/1xlEQPu3hoaKiMmY=; b=bINl+Xkfr4GqiL7OlPEQYpOdd5JoweKfb7oDNtcC33WXfWy7uP48uS6qkC2ikEiMD76HUz 9/pU2QGsVelLIXAy56cjmoJOEpPSht9YvX8akZRi4UHNMTcHqGb2+JCVSbLStoMQCPllcM EktOOpTDhATHresoMMCNnSdiMqv5q2Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-580-rO72dSFCOZiYY0hE1_Mh4Q-1; Thu, 07 Jan 2021 11:43:24 -0500 X-MC-Unique: rO72dSFCOZiYY0hE1_Mh4Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A5A60EC1A1; Thu, 7 Jan 2021 16:43:22 +0000 (UTC) Received: from [10.36.110.9] (unknown [10.36.110.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1029F1002391; Thu, 7 Jan 2021 16:43:20 +0000 (UTC) To: Joyce Kong , chenbo.xia@intel.com, honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com Cc: dev@dpdk.org, nd@arm.com References: <20201221155033.6771-1-joyce.kong@arm.com> <20201221155033.6771-5-joyce.kong@arm.com> From: Maxime Coquelin Message-ID: <915fe5de-598c-8af0-189d-c6827291270e@redhat.com> Date: Thu, 7 Jan 2021 17:43:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201221155033.6771-5-joyce.kong@arm.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1 4/8] vhost: remove unnecessary smp barrier for avail idx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/21/20 4:50 PM, Joyce Kong wrote: > The ordering between avail index and desc reads has been enforced > by load-acquire for split vring, so smp_rmb barrier is not needed > behind it. > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang > --- > lib/librte_vhost/virtio_net.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime