From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] bus/pci: fix vfio device reset Date: Tue, 31 Oct 2017 19:24:42 +0100 Message-ID: <9161630.57FQBGedkL@xps> References: <20171028062255.11910-1-jerin.jacob@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Jonas Pfefferle1 , Anatoly Burakov To: Jerin Jacob Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 588691B218 for ; Tue, 31 Oct 2017 19:24:44 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/10/2017 12:54, Jonas Pfefferle1: > Jerin Jacob wrote on 28/10/2017 08:22:55: > > If the device is not capable of resetting, then Linux kernel updates > > the errno as EINVAL. > > https://urldefense.proofpoint.com/v2/url? > > u=http-3A__elixir.free-2Delectrons.com_linux_v4. > > 9_source_drivers_vfio_pci_vfio-5Fpci.c-23L887&d=DwIBAg&c=jf_iaSHvJObTbx- > > siA1ZOg&r=rOdXhRsgn8Iur7bDE0vgwvo6TC8OpoDN-pXjigIjRW0&m=V- > > sbOkvx7qxOMbwyk3n1Fb_1NCjAhl0io- > > hqldJ0r6M&s=OXV7lrxTpahVIsA3J3nCNUlLqW21nlMiQiYveAzyQhc&e= > > > > Honor the EINVAL errno value to avoid pci vfio setup failure. > > > > Fixes: f25f8f367644 ("bus/pci: check VFIO reset ioctl error") > > > > Cc: Jonas Pfefferle > > Cc: Anatoly Burakov > > > > Signed-off-by: Jerin Jacob > > Looks good to me. > > Reviewed-by: Jonas Pfefferle > > Thanks, > Jonas Applied, thanks