From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] net/fm10k: fix RSS hash config
Date: Fri, 22 Jul 2016 10:21:34 +0200
Message-ID: <91849256.XuHjXYpFvk@xps13>
References: <1469089470-5764-1-git-send-email-xiao.w.wang@intel.com>
 <4341B239C0EFF9468EE453F9E9F4604D044DECE4@shsmsx102.ccr.corp.intel.com>
 <B7F2E978279D1D49A3034B7786DACF403DC17A43@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Wang, Xiao W" <xiao.w.wang@intel.com>, "Lin,
 Xueqin" <xueqin.lin@intel.com>
To: "Chen, Jing D" <jing.d.chen@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com
 [209.85.215.46]) by dpdk.org (Postfix) with ESMTP id 8E34C4AAD
 for <dev@dpdk.org>; Fri, 22 Jul 2016 10:21:36 +0200 (CEST)
Received: by mail-lf0-f46.google.com with SMTP id l69so79723348lfg.1
 for <dev@dpdk.org>; Fri, 22 Jul 2016 01:21:36 -0700 (PDT)
In-Reply-To: <B7F2E978279D1D49A3034B7786DACF403DC17A43@SHSMSX101.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-07-21 09:35, Wang, Xiao W:
> From: Chen, Jing D
> > > --- a/drivers/net/fm10k/fm10k_ethdev.c
> > > +++ b/drivers/net/fm10k/fm10k_ethdev.c
> > > @@ -2159,8 +2159,8 @@ fm10k_rss_hash_update(struct rte_eth_dev *dev,
> > >
> > >  	PMD_INIT_FUNC_TRACE();
> > >
> > > -	if (rss_conf->rss_key_len < FM10K_RSSRK_SIZE *
> > > -		FM10K_RSSRK_ENTRIES_PER_REG)
> > > +	if (key && (rss_conf->rss_key_len < FM10K_RSSRK_SIZE *
> > > +				FM10K_RSSRK_ENTRIES_PER_REG))
> > >  		return -EINVAL;
> > >
> > >  	if (hf == 0)
> > 
> > It's also possible that app wants to update rss key and not expect to update hash
> > function.
> > Is that indicate we shouldn't return error in case hf == 0?
> > 
> 
> If the app just wants to update RSS key, it needs to read out the RSS config first, then
> change only the key field. This is what testpmd does for this operation.
> 
> hf == 0 will disable RSS feature, I think we should return error to protect multi-queue.

Jing, do you confirm we can apply this patch, please?