dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Bruce Richardson
	<bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org,
	jigsaw <jigsaw-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] Add user defined tag calculation callback to librte_distributor.
Date: Thu, 06 Nov 2014 11:36:09 +0100	[thread overview]
Message-ID: <9190772.1rnKUO3oNV@xps13> (raw)
In-Reply-To: <20141106092228.GA3056@bricha3-MOBL3>

2014-11-06 09:22, Bruce Richardson:
> On Wed, Nov 05, 2014 at 07:24:13PM +0200, jigsaw wrote:
> > http://dpdk.org/browse/dpdk/tree/lib/librte_distributor/rte_distributor.c#n285
> > 
> >         new_tag = (next_mb->hash.rss | 1);
> > 
> > Why the logical OR is needed?
> 
> That's needed to ensure that we never track a tag with an actual value of zero.
> We instead always force the low bit to be 1, so that we can use zero as an
> "empty" value.

Bruce, could you check how this code may be better commented please?
This discussion shows that the distributor library probably needs more
explanations in the code or doxygen.

Thanks
-- 
Thomas

  parent reply	other threads:[~2014-11-06 10:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05 13:30 [PATCH] Add user defined tag calculation callback to librte_distributor Qinglai Xiao
     [not found] ` <1415194237-1219-1-git-send-email-jigsaw-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-05 14:27   ` Bruce Richardson
2014-11-05 15:11     ` jigsaw
     [not found]       ` <CAHVfvh4yAdF-aDnV+sh+PgJpEUW18+aF0=JoZDwJtGHhh=5ZzQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-05 16:36         ` Bruce Richardson
2014-11-05 17:24           ` jigsaw
     [not found]             ` <CAHVfvh4X_sUPUzSJTqBdEnkS94t2Jwj_98Vg0xbUS3MPSeo2ZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-06  9:22               ` Bruce Richardson
2014-11-06 10:14                 ` jigsaw
2014-11-06 10:36                 ` Thomas Monjalon [this message]
2014-11-06 12:36                   ` 答复: [PATCH] Add user defined tag calculation callback tolibrte_distributor Qinglai Xiao
     [not found]                     ` <545b6b74.a96db40a.26af.ffffe7fb-ATjtLOhZ0NVl57MIdRCFDg@public.gmane.org>
2014-11-06 13:59                       ` Bruce Richardson
2014-11-06 18:01                         ` jigsaw
     [not found]                           ` <CAHVfvh4U4PZKZSue_kKDQKATC2snb_=10OD08LGmUtieBc_LzA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-06 19:52                             ` jigsaw
     [not found]                               ` <CAHVfvh5SzJ-kpQQ9h=1wmMihiitcJXeR9mcNa1in8x6Gb6tSqQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-07  9:45                                 ` Bruce Richardson
2014-11-07 12:38                                   ` jigsaw
     [not found]                                     ` <CAHVfvh6y4f7+bMhzmwOu5c0Y4wzwNaxj4sQPtq8cabGbdHrzXg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-07 13:53                                       ` Bruce Richardson
2014-11-07 14:31                                         ` jigsaw
     [not found]                                           ` <CAHVfvh7ggGB_q1Rs1c3-9PRwDr_GKA+etaMXRSeKCfUKoUx8hQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-07 14:44                                             ` Bruce Richardson
2014-11-07 14:52                                               ` jigsaw
     [not found]                                                 ` <CAHVfvh6HxAVynbvCXFESMfFyHpiaLkgUPwM7eWEjNAF53qJDXg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-07 15:04                                                   ` Bruce Richardson
2014-11-07 15:18                                                     ` jigsaw
2014-11-06 13:55                   ` [PATCH] distributor: add comments to make code more readable Bruce Richardson
     [not found]                     ` <1415282132-11056-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-07 14:08                       ` Thomas Monjalon
2014-11-07 14:31                         ` jigsaw
2014-11-06 13:57                   ` [PATCH] Add user defined tag calculation callback to librte_distributor Bruce Richardson
2014-11-05 15:13     ` Ananyev, Konstantin
     [not found]       ` <2601191342CEEE43887BDE71AB977258213A2938-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-05 15:24         ` jigsaw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9190772.1rnKUO3oNV@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=jigsaw-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).