From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wiles, Keith" <keith.wiles@intel.com>
Subject: Re: [PATCH 3/3] drivers/net:build support for new tap
 device driver
Date: Fri, 16 Sep 2016 14:46:08 +0000
Message-ID: <91EC63C0-0FCE-48FA-A1E4-DF51A10DA8DC@intel.com>
References: <1473948649-14169-1-git-send-email-keith.wiles@intel.com>
 <1473948649-14169-3-git-send-email-keith.wiles@intel.com>
 <89bb7bfa-aab3-1de5-a622-c2cfebe028af@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Panu Matilainen <pmatilai@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 5E953590B
 for <dev@dpdk.org>; Fri, 16 Sep 2016 16:46:11 +0200 (CEST)
In-Reply-To: <89bb7bfa-aab3-1de5-a622-c2cfebe028af@redhat.com>
Content-Language: en-US
Content-ID: <A0F2BF5CFCB47C47A56D2DCB5A324C5E@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


Regards,
Keith

> On Sep 16, 2016, at 2:36 AM, Panu Matilainen <pmatilai@redhat.com> wrote:
>=20
> On 09/15/2016 05:10 PM, Keith Wiles wrote:
>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
>> ---
>> config/common_linuxapp | 3 +++
>> drivers/net/Makefile   | 1 +
>> mk/rte.app.mk          | 1 +
>> 3 files changed, 5 insertions(+)
>>=20
>> diff --git a/config/common_linuxapp b/config/common_linuxapp
>> index 2483dfa..704c01c 100644
>> --- a/config/common_linuxapp
>> +++ b/config/common_linuxapp
>> @@ -44,3 +44,6 @@ CONFIG_RTE_LIBRTE_PMD_VHOST=3Dy
>> CONFIG_RTE_LIBRTE_PMD_AF_PACKET=3Dy
>> CONFIG_RTE_LIBRTE_POWER=3Dy
>> CONFIG_RTE_VIRTIO_USER=3Dy
>> +CONFIG_RTE_LIBRTE_PMD_TAP=3Dy
>> +CONFIG_RTE_PMD_TAP_MAX_QUEUES=3D32
>> +
>> diff --git a/drivers/net/Makefile b/drivers/net/Makefile
>> index bc93230..b4afa98 100644
>> --- a/drivers/net/Makefile
>> +++ b/drivers/net/Makefile
>> @@ -55,6 +55,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD) +=3D thun=
derx
>> DIRS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) +=3D virtio
>> DIRS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD) +=3D vmxnet3
>> DIRS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) +=3D xenvirt
>> +DIRS-$(CONFIG_RTE_LIBRTE_PMD_TAP) +=3D tap
>>=20
>> ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y)
>> DIRS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) +=3D vhost
>> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
>> index 1a0095b..bd1d10f 100644
>> --- a/mk/rte.app.mk
>> +++ b/mk/rte.app.mk
>> @@ -129,6 +129,7 @@ ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y)
>> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_VHOST)      +=3D -lrte_pmd_vhost
>> endif # $(CONFIG_RTE_LIBRTE_VHOST)
>> _LDLIBS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD)    +=3D -lrte_pmd_vmxnet3_uio
>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_TAP)        +=3D -lrte_pmd_tap
>>=20
>> ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
>> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB)   +=3D -lrte_pmd_aesni_mb
>>=20
>=20
> Splitting the Makefile and config changes into a separate patch makes no =
sense at all in this case. Just do it in the patch introducing the driver.
>=20
> And actually, ditto for documentation.

OK, will do, but I thought other patches followed something like this as I =
had thought I was following the normally process. Without some place defini=
ng the real process it is hard to decide the real way to send patches. :-(

I will send a new single patch later today with one little typo I fixed.

>=20
> 	- Panu -