From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anand Rawat <anand.rawat@intel.com>
Subject: Re: [PATCH v7 2/8] eal: add header files to support os
 specifics
Date: Mon, 1 Apr 2019 20:52:42 -0700
Message-ID: <92030f2c-44c8-60da-b1b3-6eb251129387@intel.com>
References: <20190306041634.12976-1-anand.rawat@intel.com>
 <20190328232451.16988-1-anand.rawat@intel.com>
 <20190328232451.16988-3-anand.rawat@intel.com> <1935221.MXycTWvINB@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com,
 jeffrey.b.shaw@intel.com, bruce.richardson@intel.com,
 harini.ramakrishnan@microsoft.com, david.marchand@redhat.com
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 4C5ED4F9B
 for <dev@dpdk.org>; Tue,  2 Apr 2019 05:52:44 +0200 (CEST)
In-Reply-To: <1935221.MXycTWvINB@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/1/2019 4:09 PM, Thomas Monjalon wrote:
> Hi,
> 
> An update of the legacy Makefiles is missing.
> It should be something like that:
> 
> --- a/lib/librte_eal/freebsd/eal/Makefile
> +++ b/lib/librte_eal/freebsd/eal/Makefile
> @@ -86,7 +86,7 @@ CFLAGS_eal_thread.o += -Wno-return-type
>   CFLAGS_eal_hpet.o += -Wno-return-type
>   endif
>   
> -INC :=  # no bsd specific headers
> +INC := rte_os.h
>   
>   SYMLINK-$(CONFIG_RTE_EXEC_ENV_FREEBSD)-include := $(addprefix include/,$(INC))
>   
> --- a/lib/librte_eal/linux/eal/Makefile
> +++ b/lib/librte_eal/linux/eal/Makefile
> @@ -93,7 +93,8 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
>   CFLAGS_eal_thread.o += -Wno-return-type
>   endif
>   
> -INC := rte_kni_common.h
> +INC := rte_os.h
> +INC += rte_kni_common.h
>   
>   SYMLINK-$(CONFIG_RTE_EXEC_ENV_LINUX)-include := $(addprefix include/,$(INC))
> 

Adding the change to v8 along with a change in 
mk/target/<os>/rte.vars.mk to include path 'librte_eal/<OS>/eal/include'
for rte_os.h. This is done to make it available during the build process.

-- 
Anand Rawat