From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3] app/testpmd: print statistics periodically
Date: Mon, 19 Jun 2017 23:22:06 +0200
Message-ID: <9249424.xGZGaBmtM9@xps>
References: <20170609014656.27396-1-pablo.de.lara.guarch@intel.com>
 <20170615014817.12543-1-pablo.de.lara.guarch@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, jingjing.wu@intel.com
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 91364968
 for <dev@dpdk.org>; Mon, 19 Jun 2017 23:22:09 +0200 (CEST)
In-Reply-To: <20170615014817.12543-1-pablo.de.lara.guarch@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

15/06/2017 03:48, Pablo de Lara:
> +print_stats(void)
> +{
> +	uint8_t i;
> +	const char clr[] = { 27, '[', '2', 'J', '\0' };
> +	const char topLeft[] = { 27, '[', '1', ';', '1', 'H', '\0' };

Spotted a CamelCase ;)
Is there a punishment planned in the contributor's guide?

> +		if (stats_period != 0) {
> +			uint64_t prev_tsc = 0, cur_tsc, timer_tsc = 0;
> +			uint64_t timer_period;
> +
> +			/* Convert to number of cycles */
> +			timer_period = stats_period * rte_get_timer_hz();
> +
> +			while (1) {
> +				cur_tsc = rte_rdtsc();
> +				timer_tsc += cur_tsc - prev_tsc;

Please forget (Intel) TSC wording and prefer the more generic
rte_get_timer_cycles() function.